[Chromoting] Remove wildcard ('*') from remoting_all target.

[Chromoting] Remove wildcard ('*') from remoting_all target.

Support for the wildcard is going away in GN, so this helps prepare for the transition away from GYP.

This cl adds dummy targets so that that logic for when the proper targets should be build can be kept in the platform-specific files.

Some of the conditions in the host gyp files needed to be restructured so that the dummy targets would be defined only when necessary.  The updated conditions caused a lot of lines to be re-indented, but the target definitions are the same (except for the new dummy targets).

BUG=

Committed: https://crrev.com/9fb75ed89c0ae4ced679576f9cf030cc8c30e928
Cr-Commit-Position: refs/heads/master@{#315150}

[garykac, 2015-02-03 23:44:55]

garykac@chromium.org changed reviewers:
+ kelvinp@chromium.org

[garykac, 2015-02-03 23:44:56]

ptal. The real test is the bots, so we'll see how that goes.

https://codereview.chromium.org/896743004/diff/1/remoting/remoting_host_linux...
File remoting/remoting_host_linux.gypi (right):

https://codereview.chromium.org/896743004/diff/1/remoting/remoting_host_linux...
remoting/remoting_host_linux.gypi:88: 'target_name':
'remoting_me2me_host_archive',
New dummy target.

https://codereview.chromium.org/896743004/diff/1/remoting/remoting_host_mac.gypi
File remoting/remoting_host_mac.gypi (right):

https://codereview.chromium.org/896743004/diff/1/remoting/remoting_host_mac.g...
remoting/remoting_host_mac.gypi:9: 'variables': {
Moved for consistency with the other platform-specific host gyp files.

https://codereview.chromium.org/896743004/diff/1/remoting/remoting_host_win.gypi
File remoting/remoting_host_win.gypi (right):

https://codereview.chromium.org/896743004/diff/1/remoting/remoting_host_win.g...
remoting/remoting_host_win.gypi:620: # Dummy targets for when Wix is not
available.
New dummy targets.

[kelvinp, 2015-02-04 01:01:58]

https://codereview.chromium.org/896743004/diff/20001/remoting/remoting_host_l...
File remoting/remoting_host_linux.gypi (right):

https://codereview.chromium.org/896743004/diff/20001/remoting/remoting_host_l...
remoting/remoting_host_linux.gypi:7: ['OS=="linux"', {
Maybe we can move the conditions to remoting_host.gypi so that we can save 1
level of indentation here.

https://codereview.chromium.org/896743004/diff/20001/remoting/remoting_host_m...
File remoting/remoting_host_mac.gypi (right):

https://codereview.chromium.org/896743004/diff/20001/remoting/remoting_host_m...
remoting/remoting_host_mac.gypi:8: 
Nit: remove extra blank line

https://codereview.chromium.org/896743004/diff/20001/remoting/remoting_host_m...
remoting/remoting_host_mac.gypi:259: 
Nit: remove extra blank line

https://codereview.chromium.org/896743004/diff/20001/remoting/remoting_host_w...
File remoting/remoting_host_win.gypi (right):

https://codereview.chromium.org/896743004/diff/20001/remoting/remoting_host_w...
remoting/remoting_host_win.gypi:8: 
Nit: remove extra blank line

https://codereview.chromium.org/896743004/diff/20001/remoting/remoting_host_w...
remoting/remoting_host_win.gypi:18: 
Nit: remove extra blank line

[garykac, 2015-02-04 18:39:28]

ptal

I hoisted the OS-check out of remoting_host_* and put in a check for
it2me_native_messaging_host for chromeos.

[kelvinp, 2015-02-04 20:51:23]

PTAL

https://codereview.chromium.org/896743004/diff/80001/remoting/remoting_all.gyp
File remoting/remoting_all.gyp (right):

https://codereview.chromium.org/896743004/diff/80001/remoting/remoting_all.gy...
remoting/remoting_all.gyp:78:
'../remoting/remoting.gyp:remoting_it2me_native_messaging_host',
Or should we follow through with our dummy approach?

https://codereview.chromium.org/896743004/diff/80001/remoting/remoting_host.gypi
File remoting/remoting_host.gypi (right):

https://codereview.chromium.org/896743004/diff/80001/remoting/remoting_host.g...
remoting/remoting_host.gypi:9: ['OS=="win" or OS=="mac" or (OS=="linux" and
use_x11==1)', {
should we consolidate this variables with those in remoting_all.gyp?
and also get rid of enable_it2me_host here as well?

[garykac, 2015-02-06 02:18:41]

ptal

https://codereview.chromium.org/896743004/diff/80001/remoting/remoting_all.gyp
File remoting/remoting_all.gyp (right):

https://codereview.chromium.org/896743004/diff/80001/remoting/remoting_all.gy...
remoting/remoting_all.gyp:78:
'../remoting/remoting.gyp:remoting_it2me_native_messaging_host',
On 2015/02/04 20:51:22, kelvinp wrote:
> Or should we follow through with our dummy approach?

Done.

https://codereview.chromium.org/896743004/diff/80001/remoting/remoting_host.gypi
File remoting/remoting_host.gypi (right):

https://codereview.chromium.org/896743004/diff/80001/remoting/remoting_host.g...
remoting/remoting_host.gypi:9: ['OS=="win" or OS=="mac" or (OS=="linux" and
use_x11==1)', {
On 2015/02/04 20:51:22, kelvinp wrote:
> should we consolidate this variables with those in remoting_all.gyp?
> and also get rid of enable_it2me_host here as well?

Done.

[kelvinp, 2015-02-06 19:15:11]

lgtm with a Nit on updating a comment.

https://codereview.chromium.org/896743004/diff/120001/remoting/remoting_enabl...
File remoting/remoting_enable.gypi (right):

https://codereview.chromium.org/896743004/diff/120001/remoting/remoting_enabl...
remoting/remoting_enable.gypi:11: # Remoting host is supported only on Windows,
OSX and Linux (with X11).
This comment needs to be updated.

[garykac, 2015-02-06 23:52:35]

New patchsets have been uploaded after l-g-t-m from kelvinp@chromium.org

[garykac, 2015-02-06 23:53:11]

https://codereview.chromium.org/896743004/diff/120001/remoting/remoting_enabl...
File remoting/remoting_enable.gypi (right):

https://codereview.chromium.org/896743004/diff/120001/remoting/remoting_enabl...
remoting/remoting_enable.gypi:11: # Remoting host is supported only on Windows,
OSX and Linux (with X11).
On 2015/02/06 19:15:10, kelvinp wrote:
> This comment needs to be updated.

Done.

[garykac, 2015-02-06 23:53:14]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2015-02-06 23:53:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896743004/140001

[commit-bot: I haz the power, 2015-02-07 00:47:19]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-02-07 00:47:51]

Patchset 8 (id:??) landed as
https://crrev.com/9fb75ed89c0ae4ced679576f9cf030cc8c30e928
Cr-Commit-Position: refs/heads/master@{#315150}

[bshe, 2015-02-09 03:23:37]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/905223002/ by bshe@chromium.org.

The reason for reverting is: It cause ChromiumOS.Chromium and PFQ bots to fail.
The reason might because chroot didn't have "dpkg-architecture" command. The
correct solution might be add "dpkg-architecture" command to chroot. But this CL
currently break PFQ and a bunch of bots. So revert it for immediate fix.
See crbug.com/456491.