Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 896733002: Revert of offset namespace ids (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
michaeln, jsbell
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of offset namespace ids (patchset #7 id:120001 of https://codereview.chromium.org/881253004/) Reason for revert: Tests now only work if they ran in the "right" order. DOMStorageContextImplTest.Basic fails if the tests are shuffled: content_unittests --gtest_filter=DOMStorageContextImplTest.*:DOMStorageAreaTest.* --gtest_shuffle Original issue's description: > [DOMStorage] Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another. > > Committed: https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e > Cr-Commit-Position: refs/heads/master@{#314256} TBR=jsbell@chromium.org,michaeln@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7bdc4a49e605261b60ee1339f93e835d853bf645 Cr-Commit-Position: refs/heads/master@{#314274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M content/browser/dom_storage/dom_storage_context_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl.cc View 4 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of offset namespace ids
5 years, 10 months ago (2015-02-03 05:40:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896733002/1
5 years, 10 months ago (2015-02-03 05:40:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 05:41:48 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 05:42:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bdc4a49e605261b60ee1339f93e835d853bf645
Cr-Commit-Position: refs/heads/master@{#314274}

Powered by Google App Engine
This is Rietveld 408576698