Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: media/base/video_renderer.h

Issue 89673002: Allow Preroll() call on VideoRendererImpl without a Flush(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and Address CR comments. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/video_renderer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_renderer.h
diff --git a/media/base/video_renderer.h b/media/base/video_renderer.h
index 84ce6cfa0171c4e68ec1a1e8b49f8ba0cb0f80e0..2650221e3d89306e893e9bcdbd0094433680e37b 100644
--- a/media/base/video_renderer.h
+++ b/media/base/video_renderer.h
@@ -74,10 +74,13 @@ class MEDIA_EXPORT VideoRenderer {
// Discard any video data, executing |callback| when completed.
virtual void Flush(const base::Closure& callback) = 0;
- // Start prerolling video data for samples starting at |time|, executing
- // |callback| when completed.
+ // Start prerolling video data. If |time| equals kNoTimestamp() then all
+ // samples delivered to the renderer are used to complete preroll. If |time|
+ // does not equal kNoTimestamp(), then any samples delivered to the renderer
+ // with timestamps less than |time| are silently dropped and not used to
+ // satisfy preroll. |callback| is executed when preroll has completed.
//
- // Only valid to call after a successful Initialize() or Flush().
+ // Only valid to call after a successful Initialize(), Pause(), or Flush().
virtual void Preroll(base::TimeDelta time,
const PipelineStatusCB& callback) = 0;
« no previous file with comments | « no previous file | media/filters/video_renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698