Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 896723006: Avoid double registration with content settings in account reconcilor. (Closed)

Created:
5 years, 10 months ago by msarda
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Roger Tawa OOO till Jul 10th
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid double registration with content settings in account reconcilor. This CL avoids a double registration for content settings in account rconcilor as this leads to a DCHECK being fired during a reauthentication operation. BUG=454507 Committed: https://crrev.com/4555495af33c594ec5b8e3d8340116978c4287cc Cr-Commit-Position: refs/heads/master@{#314409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M components/signin/core/browser/account_reconcilor.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
msarda
Please take a look.
5 years, 10 months ago (2015-02-03 16:02:08 UTC) #2
msarda
Changing reviewers as Roger is not available this week. Drew: Please take a look.
5 years, 10 months ago (2015-02-03 16:28:59 UTC) #4
Andrew T Wilson (Slow)
lgtm
5 years, 10 months ago (2015-02-03 16:51:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896723006/1
5 years, 10 months ago (2015-02-03 21:43:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 21:47:05 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 21:48:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4555495af33c594ec5b8e3d8340116978c4287cc
Cr-Commit-Position: refs/heads/master@{#314409}

Powered by Google App Engine
This is Rietveld 408576698