Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 896723003: Disable PasswordManagerBrowserTest.PasswordValueAccessibleOnSubmit which is quite flaky. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/histogram_samples.h" 8 #include "base/metrics/histogram_samples.h"
9 #include "base/metrics/statistics_recorder.h" 9 #include "base/metrics/statistics_recorder.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 WaitForElementValue("password_field", "random"); 1018 WaitForElementValue("password_field", "random");
1019 // And check that after the side-effects of the interaction took place, the 1019 // And check that after the side-effects of the interaction took place, the
1020 // username value stays the same. 1020 // username value stays the same.
1021 CheckElementValue("username_field", "temp"); 1021 CheckElementValue("username_field", "temp");
1022 } 1022 }
1023 1023
1024 // The following test is limited to Aura, because 1024 // The following test is limited to Aura, because
1025 // RenderWidgetHostViewGuest::ProcessAckedTouchEvent is, and 1025 // RenderWidgetHostViewGuest::ProcessAckedTouchEvent is, and
1026 // ProcessAckedTouchEvent is what triggers the translation of touch events to 1026 // ProcessAckedTouchEvent is what triggers the translation of touch events to
1027 // gesture events. 1027 // gesture events.
1028 // Disabled: http://crbug.com/346297
1028 #if defined(USE_AURA) 1029 #if defined(USE_AURA)
1029 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, 1030 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
1030 PasswordValueAccessibleOnSubmit) { 1031 DISABLED_PasswordValueAccessibleOnSubmit) {
1031 NavigateToFile("/password/form_and_link.html"); 1032 NavigateToFile("/password/form_and_link.html");
1032 1033
1033 // Fill in the credentials, and make sure they are saved. 1034 // Fill in the credentials, and make sure they are saved.
1034 NavigationObserver form_submit_observer(WebContents()); 1035 NavigationObserver form_submit_observer(WebContents());
1035 scoped_ptr<PromptObserver> prompt_observer( 1036 scoped_ptr<PromptObserver> prompt_observer(
1036 PromptObserver::Create(WebContents())); 1037 PromptObserver::Create(WebContents()));
1037 std::string fill_and_submit = 1038 std::string fill_and_submit =
1038 "document.getElementById('username_field').value = 'temp';" 1039 "document.getElementById('username_field').value = 'temp';"
1039 "document.getElementById('password_field').value = 'random_secret';" 1040 "document.getElementById('password_field').value = 'random_secret';"
1040 "document.getElementById('input_submit_button').click();"; 1041 "document.getElementById('input_submit_button').click();";
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
1575 std::string fill_and_submit = 1576 std::string fill_and_submit =
1576 "document.getElementById('chg_not_username_field').value = 'temp';" 1577 "document.getElementById('chg_not_username_field').value = 'temp';"
1577 "document.getElementById('chg_password_field').value = 'random';" 1578 "document.getElementById('chg_password_field').value = 'random';"
1578 "document.getElementById('chg_new_password_1').value = 'random1';" 1579 "document.getElementById('chg_new_password_1').value = 'random1';"
1579 "document.getElementById('chg_new_password_2').value = 'random1';" 1580 "document.getElementById('chg_new_password_2').value = 'random1';"
1580 "document.getElementById('chg_submit_button').click()"; 1581 "document.getElementById('chg_submit_button').click()";
1581 ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit)); 1582 ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
1582 observer.Wait(); 1583 observer.Wait();
1583 EXPECT_FALSE(prompt_observer->IsShowingPrompt()); 1584 EXPECT_FALSE(prompt_observer->IsShowingPrompt());
1584 } 1585 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698