Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 896713003: Revert of DataReductionProxyStatisticsPrefs should support WeakPtr (Closed)

Created:
5 years, 10 months ago by jiayl
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DataReductionProxyStatisticsPrefs should support WeakPtr (patchset #10 id:450001 of https://codereview.chromium.org/888713002/) Reason for revert: Suspected to cause compile failure: http://build.chromium.org/p/chromium.mac/builders/iOS%20Device/builds/23577/steps/compile/logs/stdio Original issue's description: > DataReductionProxyStatisticsPrefs should support WeakPtr > > The DRPStatisticsPrefs object is referenced via a raw pointer in > DRPNetworkDelegate and DRPSettings. It should instead be referenced > via WeakPtr. > > BUG=453155, 455559, 444939 > > Committed: https://crrev.com/149bd770d674e8125f81cd649a8deece3a851682 > Cr-Commit-Position: refs/heads/master@{#315419} TBR=bengr@chromium.org,sgurun@chromium.org,mmenke@chromium.org,megjablon@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453155, 455559, 444939 Committed: https://crrev.com/459c1ac559bed513908b594d63c84817ce63e0c9 Cr-Commit-Position: refs/heads/master@{#315424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -335 lines) Patch
M android_webview/browser/aw_browser_context.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc View 2 chunks +1 line, -12 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h View 4 chunks +10 lines, -10 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 6 chunks +19 lines, -17 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.h View 1 chunk +8 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h View 5 chunks +2 lines, -14 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 4 chunks +8 lines, -35 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 12 chunks +134 lines, -164 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h View 4 chunks +5 lines, -15 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h View 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jiayl
Created Revert of DataReductionProxyStatisticsPrefs should support WeakPtr
5 years, 10 months ago (2015-02-09 23:19:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896713003/1
5 years, 10 months ago (2015-02-09 23:21:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 23:22:46 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/459c1ac559bed513908b594d63c84817ce63e0c9 Cr-Commit-Position: refs/heads/master@{#315424}
5 years, 10 months ago (2015-02-09 23:23:14 UTC) #4
bengr
5 years, 10 months ago (2015-02-09 23:31:33 UTC) #5
Message was sent while issue was closed. 
Hey, I don't understand. It looks like ios was behind. That shouldn't
result in a revert.

On Mon, Feb 9, 2015 at 3:23 PM, <commit-bot@chromium.org> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/459c1ac559bed513908b594d63c84817ce63e0c9
> Cr-Commit-Position: refs/heads/master@{#315424}
>
> https://codereview.chromium.org/896713003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698