Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 896703003: [linux] Improve link time with Chromium-bundled binutils. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[linux] Improve link time with Chromium-bundled binutils. Also enabled concurrent linking with gold on Linux. Mostly copy and paste from Chromium with customization for V8 where necessary. BUG=v8:3880 LOG=n Committed: https://crrev.com/e06dc0569a01cff00cd8d726457015182bea8f98 Cr-Commit-Position: refs/heads/master@{#26536}

Patch Set 1 #

Patch Set 2 : Use concurrent linking in debug builds only. Cleanup variables. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -0 lines) Patch
M DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
M build/toolchain.gypi View 1 3 chunks +75 lines, -0 lines 0 comments Download
A third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/binutils/download.py View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-10 07:22:14 UTC) #2
Sven Panne
LGTM (mostly rubber-stamped)
5 years, 10 months ago (2015-02-10 07:25:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896703003/20001
5 years, 10 months ago (2015-02-10 07:26:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-10 07:27:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 07:27:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e06dc0569a01cff00cd8d726457015182bea8f98
Cr-Commit-Position: refs/heads/master@{#26536}

Powered by Google App Engine
This is Rietveld 408576698