Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 896693002: Add text continuation for 'Remove from Chrome' in Mac app list context menu (Closed)

Created:
5 years, 10 months ago by tsergeant
Modified:
5 years, 10 months ago
Reviewers:
tapted, sashab
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sashab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add text continuation for 'Remove from Chrome' in Mac app list context menu The OSX interface guidelines suggest that this case should have a continuation, and a continuation is used for this option in chrome://apps. BUG=444813 Committed: https://crrev.com/c3548e1bddc58e07ffe177c621882f1ce09d92b5 Cr-Commit-Position: refs/heads/master@{#315247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -64 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +6 lines, -20 lines 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +8 lines, -24 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +6 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
tsergeant
tapted, can you take a look a this?
5 years, 10 months ago (2015-02-03 02:38:31 UTC) #2
tsergeant
CC sasha_b, can you confirm whether it's okay to remove this? (was it raised in ...
5 years, 10 months ago (2015-02-03 03:14:25 UTC) #3
sashab
I think we may need to add text continuation in Mac, and remove it from ...
5 years, 10 months ago (2015-02-06 15:52:11 UTC) #5
sashab
And... UI says its all OK! So lgtm. And thanks for fixing it everywhere. :)
5 years, 10 months ago (2015-02-06 18:34:04 UTC) #6
tapted
Sweet! lgtm
5 years, 10 months ago (2015-02-08 23:18:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896693002/1
5 years, 10 months ago (2015-02-08 23:20:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 00:10:34 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 00:11:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3548e1bddc58e07ffe177c621882f1ce09d92b5
Cr-Commit-Position: refs/heads/master@{#315247}

Powered by Google App Engine
This is Rietveld 408576698