chrome/browser/android/chrome_web_contents_delegate_android.cc - Issue 896673003: Propagate audible state from player to the containing tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_web_contents_delegate_android.cc

Issue 896673003: Propagate audible state from player to the containing tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments by Daniel and Min Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java ('k') | content/browser/android/media_players_observer.h » ('j') | content/browser/media/audio_stream_monitor_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_web_contents_delegate_android.cc

diff --git a/chrome/browser/android/chrome_web_contents_delegate_android.cc b/chrome/browser/android/chrome_web_contents_delegate_android.cc

index 8194f89dd8baf4708623f6c9cc3eed655ee8e84e..7a141d0b880ca37af79b29df5df076f3dd21bc4a 100644

--- a/chrome/browser/android/chrome_web_contents_delegate_android.cc

+++ b/chrome/browser/android/chrome_web_contents_delegate_android.cc

@@ -43,6 +43,7 @@ using base::android::AttachCurrentThread;

using base::android::ScopedJavaLocalRef;

using content::FileChooserParams;

using content::WebContents;

+using content::WebContentsImpl;

namespace {

@@ -371,3 +372,8 @@ jboolean IsCapturingVideo(JNIEnv* env,

return indicator->IsCapturingVideo(web_contents);

}

+jboolean IsPlayingAudio(JNIEnv* env,

+ jclass clazz,

+ jobject java_web_contents) {

+ return false; // not implemented