Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: content/browser/media/audio_stream_monitor.cc

Issue 896673003: Propagate audible state from player to the containing tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: AudioStreamMonitor and corresponding Android monitor now have common base class Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/audio_stream_monitor.cc
diff --git a/content/browser/media/audio_stream_monitor.cc b/content/browser/media/audio_stream_monitor.cc
index 1d2f76f7f2c02f986f5b52122834363ff96be1e8..3f65e7b29171f659d21f1e82102fced73d4ae8f9 100644
--- a/content/browser/media/audio_stream_monitor.cc
+++ b/content/browser/media/audio_stream_monitor.cc
@@ -21,23 +21,33 @@ AudioStreamMonitor* AudioStreamMonitorFromRenderFrame(int render_process_id,
WebContentsImpl* const web_contents =
static_cast<WebContentsImpl*>(WebContents::FromRenderFrameHost(
RenderFrameHost::FromID(render_process_id, render_frame_id)));
- return web_contents ? web_contents->audio_stream_monitor() : NULL;
+
+ if (!web_contents)
+ return nullptr;
+
+ AudioStateProvider* audio_provider = web_contents->audio_state_provider();
+ return audio_provider ? audio_provider->audio_stream_monitor() : nullptr;
}
} // namespace
AudioStreamMonitor::AudioStreamMonitor(WebContents* contents)
- : web_contents_(contents),
- clock_(&default_tick_clock_),
- was_recently_audible_(false) {
- DCHECK(web_contents_);
+ : AudioStateProvider(contents),
+ clock_(&default_tick_clock_)
+{
}
AudioStreamMonitor::~AudioStreamMonitor() {}
+
+// This provider is the monitor.
+AudioStreamMonitor* AudioStreamMonitor::audio_stream_monitor() {
+ return this;
+}
+
bool AudioStreamMonitor::WasRecentlyAudible() const {
DCHECK(thread_checker_.CalledOnValidThread());
- return was_recently_audible_;
+ return AudioStateProvider::WasRecentlyAudible();
}
// static
@@ -138,16 +148,12 @@ void AudioStreamMonitor::Poll() {
}
void AudioStreamMonitor::MaybeToggle() {
- const bool indicator_was_on = was_recently_audible_;
const base::TimeTicks off_time =
last_blurt_time_ + base::TimeDelta::FromMilliseconds(kHoldOnMilliseconds);
const base::TimeTicks now = clock_->NowTicks();
const bool should_indicator_be_on = now < off_time;
- if (should_indicator_be_on != indicator_was_on) {
- was_recently_audible_ = should_indicator_be_on;
- web_contents_->NotifyNavigationStateChanged(INVALIDATE_TYPE_TAB);
- }
+ Notify(should_indicator_be_on);
if (!should_indicator_be_on) {
off_timer_.Stop();

Powered by Google App Engine
This is Rietveld 408576698