Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Side by Side Diff: content/browser/media/media_web_contents_observer.cc

Issue 896673003: Propagate audible state from player to the containing tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments by Daniel and Min Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/media/media_web_contents_observer.h" 5 #include "content/browser/media/media_web_contents_observer.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/stl_util.h" 8 #include "base/stl_util.h"
9 #include "content/browser/media/cdm/browser_cdm_manager.h" 9 #include "content/browser/media/cdm/browser_cdm_manager.h"
10 #include "content/browser/renderer_host/render_process_host_impl.h" 10 #include "content/browser/renderer_host/render_process_host_impl.h"
11 #include "content/browser/web_contents/web_contents_impl.h"
11 #include "content/public/browser/render_frame_host.h" 12 #include "content/public/browser/render_frame_host.h"
12 #include "content/public/browser/web_contents.h" 13 #include "content/public/browser/web_contents.h"
13 #include "ipc/ipc_message_macros.h" 14 #include "ipc/ipc_message_macros.h"
14 15
15 #if defined(OS_ANDROID) 16 #if defined(OS_ANDROID)
17 #include "content/browser/android/media_players_observer.h"
16 #include "content/browser/media/android/browser_media_player_manager.h" 18 #include "content/browser/media/android/browser_media_player_manager.h"
17 #include "content/common/media/media_player_messages_android.h" 19 #include "content/common/media/media_player_messages_android.h"
18 #include "media/base/android/media_player_android.h" 20 #include "media/base/android/media_player_android.h"
19 #endif // defined(OS_ANDROID) 21 #endif // defined(OS_ANDROID)
20 22
21 namespace content { 23 namespace content {
22 24
23 MediaWebContentsObserver::MediaWebContentsObserver( 25 MediaWebContentsObserver::MediaWebContentsObserver(
24 WebContents* web_contents) 26 WebContents* web_contents)
25 : WebContentsObserver(web_contents) { 27 : WebContentsObserver(web_contents)
28 {
26 } 29 }
27 30
28 MediaWebContentsObserver::~MediaWebContentsObserver() { 31 MediaWebContentsObserver::~MediaWebContentsObserver() {
29 } 32 }
30 33
31 void MediaWebContentsObserver::RenderFrameDeleted( 34 void MediaWebContentsObserver::RenderFrameDeleted(
32 RenderFrameHost* render_frame_host) { 35 RenderFrameHost* render_frame_host) {
33 #if defined(OS_ANDROID) 36 #if defined(OS_ANDROID)
34 uintptr_t key = reinterpret_cast<uintptr_t>(render_frame_host); 37 uintptr_t key = reinterpret_cast<uintptr_t>(render_frame_host);
35 // Always destroy the media players before CDMs because we do not support 38 // Always destroy the media players before CDMs because we do not support
36 // detaching CDMs from media players yet. See http://crbug.com/330324 39 // detaching CDMs from media players yet. See http://crbug.com/330324
37 media_player_managers_.erase(key); 40 media_player_managers_.erase(key);
41
42 if (!static_cast<WebContentsImpl*>(web_contents())->IsBeingDestroyed()) {
43 MediaPlayersObserver* audio_observer = GetMediaPlayersObserver();
44 if (audio_observer)
45 audio_observer->RenderFrameDeleted(render_frame_host);
Tima Vaisburd 2015/03/02 18:37:30 Can we rely upon MediaPlayersObserver::BrowserMedi
46 }
38 #endif 47 #endif
39 // TODO(xhwang): Currently MediaWebContentsObserver, BrowserMediaPlayerManager 48 // TODO(xhwang): Currently MediaWebContentsObserver, BrowserMediaPlayerManager
40 // and BrowserCdmManager all run on browser UI thread. So this call is okay. 49 // and BrowserCdmManager all run on browser UI thread. So this call is okay.
41 // In the future we need to support the case where MediaWebContentsObserver 50 // In the future we need to support the case where MediaWebContentsObserver
42 // get notified on browser UI thread, but BrowserMediaPlayerManager and 51 // get notified on browser UI thread, but BrowserMediaPlayerManager and
43 // BrowserCdmManager run on a different thread. 52 // BrowserCdmManager run on a different thread.
44 BrowserCdmManager* browser_cdm_manager = 53 BrowserCdmManager* browser_cdm_manager =
45 BrowserCdmManager::FromProcess(render_frame_host->GetProcess()->GetID()); 54 BrowserCdmManager::FromProcess(render_frame_host->GetProcess()->GetID());
46 if (browser_cdm_manager) 55 if (browser_cdm_manager)
47 browser_cdm_manager->RenderFrameDeleted(render_frame_host->GetRoutingID()); 56 browser_cdm_manager->RenderFrameDeleted(render_frame_host->GetRoutingID());
48 } 57 }
49 58
59
50 #if defined(OS_ANDROID) 60 #if defined(OS_ANDROID)
51 61
52 bool MediaWebContentsObserver::OnMessageReceived( 62 bool MediaWebContentsObserver::OnMessageReceived(
53 const IPC::Message& msg, 63 const IPC::Message& msg,
54 RenderFrameHost* render_frame_host) { 64 RenderFrameHost* render_frame_host) {
55 if (OnMediaPlayerMessageReceived(msg, render_frame_host)) 65 if (OnMediaPlayerMessageReceived(msg, render_frame_host))
56 return true; 66 return true;
57 67
58 if (OnMediaPlayerSetCdmMessageReceived(msg, render_frame_host)) 68 if (OnMediaPlayerSetCdmMessageReceived(msg, render_frame_host))
59 return true; 69 return true;
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 // promise. 164 // promise.
155 media_player->SetCdm(cdm); 165 media_player->SetCdm(cdm);
156 } 166 }
157 167
158 BrowserMediaPlayerManager* MediaWebContentsObserver::GetMediaPlayerManager( 168 BrowserMediaPlayerManager* MediaWebContentsObserver::GetMediaPlayerManager(
159 RenderFrameHost* render_frame_host) { 169 RenderFrameHost* render_frame_host) {
160 uintptr_t key = reinterpret_cast<uintptr_t>(render_frame_host); 170 uintptr_t key = reinterpret_cast<uintptr_t>(render_frame_host);
161 if (!media_player_managers_.contains(key)) { 171 if (!media_player_managers_.contains(key)) {
162 media_player_managers_.set( 172 media_player_managers_.set(
163 key, 173 key,
164 make_scoped_ptr(BrowserMediaPlayerManager::Create(render_frame_host))); 174 make_scoped_ptr(BrowserMediaPlayerManager::Create(
175 render_frame_host, GetMediaPlayersObserver())));
165 } 176 }
166 return media_player_managers_.get(key); 177 return media_player_managers_.get(key);
167 } 178 }
168 179
180 MediaPlayersObserver*
181 MediaWebContentsObserver::GetMediaPlayersObserver() const {
182 AudioStateProvider* provider =
183 static_cast<WebContentsImpl*>(web_contents())->audio_state_provider();
184
185 MediaPlayersObserver* audio_observer =
186 static_cast<MediaPlayersObserver*>(provider);
187
188 DCHECK(audio_observer);
189 return audio_observer;
190 }
191
169 #if defined(VIDEO_HOLE) 192 #if defined(VIDEO_HOLE)
170 void MediaWebContentsObserver::OnFrameInfoUpdated() { 193 void MediaWebContentsObserver::OnFrameInfoUpdated() {
171 for (MediaPlayerManagerMap::iterator iter = media_player_managers_.begin(); 194 for (MediaPlayerManagerMap::iterator iter = media_player_managers_.begin();
172 iter != media_player_managers_.end(); ++iter) { 195 iter != media_player_managers_.end(); ++iter) {
173 BrowserMediaPlayerManager* manager = iter->second; 196 BrowserMediaPlayerManager* manager = iter->second;
174 manager->OnFrameInfoUpdated(); 197 manager->OnFrameInfoUpdated();
175 } 198 }
176 } 199 }
177 #endif // defined(VIDEO_HOLE) 200 #endif // defined(VIDEO_HOLE)
178 201
179 #endif // defined(OS_ANDROID) 202 #endif // defined(OS_ANDROID)
180 203
181 } // namespace content 204 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698