Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 896673002: Fix the incorrect font used by buttons in ChromeOS. (Closed)

Created:
5 years, 10 months ago by xdai1
Modified:
5 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the incorrect font used by buttons in ChromeOS. WebUI should override the default Blink style for buttons so that buttons can be rendered with the correct font. BUG=448624 TEST=manually checked on devices (Pixel) Committed: https://crrev.com/8fc0f8118a42de9a52fa98cc8a3f5c9b9efa74d9 Cr-Commit-Position: refs/heads/master@{#314359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/webui/resources/css/text_defaults.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
xdai1
Please help to review the CL, thanks!
5 years, 10 months ago (2015-02-03 01:15:54 UTC) #2
xiyuan
lgtm
5 years, 10 months ago (2015-02-03 02:14:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896673002/1
5 years, 10 months ago (2015-02-03 03:56:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-02-03 05:57:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896673002/1
5 years, 10 months ago (2015-02-03 17:44:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 17:44:55 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 17:45:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fc0f8118a42de9a52fa98cc8a3f5c9b9efa74d9
Cr-Commit-Position: refs/heads/master@{#314359}

Powered by Google App Engine
This is Rietveld 408576698