minidump/minidump_rva_list_writer.h - Issue 896663006: win: Resolve zero-length array errors on MSVC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_rva_list_writer.h

Issue 896663006: win: Resolve zero-length array errors on MSVC (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump-comp

Patch Set: . Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_rva_list_writer.h

diff --git a/minidump/minidump_rva_list_writer.h b/minidump/minidump_rva_list_writer.h

index 257f2c0cd78175cde8cf87cbb7b6f204a35d9202..42bb1b515ee5e204815e0bd93e05b1099905045e 100644

--- a/minidump/minidump_rva_list_writer.h

+++ b/minidump/minidump_rva_list_writer.h

@@ -66,7 +66,7 @@ class MinidumpRVAListWriter : public MinidumpWritable {

bool WriteObject(FileWriterInterface* file_writer) override;

private:

- MinidumpRVAList rva_list_base_;

+ scoped_ptr<MinidumpRVAList> rva_list_base_;

PointerVector<MinidumpWritable> children_;

std::vector<RVA> child_rvas_;

« minidump/minidump_location_descriptor_list_writer.cc ('K') | « minidump/minidump_module_writer.cc ('k') | minidump/minidump_rva_list_writer.cc » ('j') | no next file with comments »