Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 896653008: Move nested classes of AstGraphBuilder into cc file. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_trycatch-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move nested classes of AstGraphBuilder into cc file. R=titzer@chromium.org Committed: https://crrev.com/791deaa271939fc2277f36ee26fb16e989d2d578 Cr-Commit-Position: refs/heads/master@{#26400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -116 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +3 lines, -116 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +114 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Pure refactoring, no functional changes.
5 years, 10 months ago (2015-02-03 13:56:11 UTC) #1
titzer
YEsss LGTM
5 years, 10 months ago (2015-02-03 13:58:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896653008/1
5 years, 10 months ago (2015-02-03 14:05:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 14:22:18 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 14:22:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/791deaa271939fc2277f36ee26fb16e989d2d578
Cr-Commit-Position: refs/heads/master@{#26400}

Powered by Google App Engine
This is Rietveld 408576698