Don't set the STATE_SYSTEM_HOTTRACKED state in tests.

Don't set the STATE_SYSTEM_HOTTRACKED state in tests.

It's set whenever the mouse is over an element, which just leads
to flakiness.

BUG=454600
NOPRESUBMIT=true

Committed: https://crrev.com/dea5ba683e6fbf8ad4613d07f73e12b0fa0d66eb
Cr-Commit-Position: refs/heads/master@{#314382}

[dmazzoni, 2015-02-03 00:23:48]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2015-02-03 02:19:42]

https://codereview.chromium.org/896653002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_state_impl.h (right):

https://codereview.chromium.org/896653002/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_state_impl.h:63: //
Accessibility objects can have the "hot tracked" state set when
I wonder if an easier fix to this is to just move the mouse to some known
position programmatically as part of a test's setup?

[dmazzoni, 2015-02-03 06:54:11]

https://codereview.chromium.org/896653002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_state_impl.h (right):

https://codereview.chromium.org/896653002/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_state_impl.h:63: //
Accessibility objects can have the "hot tracked" state set when
On 2015/02/03 02:19:42, David Tseng wrote:
> I wonder if an easier fix to this is to just move the mouse to some known
> position programmatically as part of a test's setup?

I think that'd be annoying for anyone who runs content_browsertests locally.
Also I think it sets a bad precedent because tests run in parallel but there's
only one mouse. If I set it to 0,0 and another test set it to 9999, 9999 they
could mess with each other and cause more flakiness. I think it's better to not
have tests depend on the local machine.

The exception is interactive_ui_tests - those tests are allowed to do things
like move the mouse, but I don't see any reason to migrate these tests there -
they'd run much more slowly since those tests can't be parallelized.

Other options would include:
* Setting the flag as a static bool in BrowserAccessibility or
BrowserAccessibilityWin instead
* Ignoring STATE_SYSTEM_HOTTRACKED when checking states in test code, rather
than changing the code being tested - this has the advantage of not messing with
the real code, but it requires remembering to do that in every test.

[David Tseng, 2015-02-03 17:59:22]

lgtm

[dmazzoni, 2015-02-03 17:59:52]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-02-03 18:00:06]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2015-02-03 18:00:09]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2015-02-03 18:00:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896653002/1

[commit-bot: I haz the power, 2015-02-03 19:28:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-03 19:28:45]

Patchset 1 (id:??) landed as
https://crrev.com/dea5ba683e6fbf8ad4613d07f73e12b0fa0d66eb
Cr-Commit-Position: refs/heads/master@{#314382}