Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: test/mjsunit/harmony/classes.js

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: formatting Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/harmony/classes.js
diff --git a/test/mjsunit/harmony/classes.js b/test/mjsunit/harmony/classes.js
index 29ffbf8d7de2ca507324bd9becb13c6734dd0c69..f57a1bad1c6e21e51f7b4343cd180595e9f4c860 100644
--- a/test/mjsunit/harmony/classes.js
+++ b/test/mjsunit/harmony/classes.js
@@ -186,7 +186,7 @@
function assertMethodDescriptor(object, name) {
var descr = Object.getOwnPropertyDescriptor(object, name);
assertTrue(descr.configurable);
- assertTrue(descr.enumerable);
+ assertFalse(descr.enumerable);
assertTrue(descr.writable);
assertEquals('function', typeof descr.value);
assertFalse('prototype' in descr.value);
@@ -196,7 +196,7 @@ function assertMethodDescriptor(object, name) {
function assertGetterDescriptor(object, name) {
var descr = Object.getOwnPropertyDescriptor(object, name);
assertTrue(descr.configurable);
- assertTrue(descr.enumerable);
+ assertFalse(descr.enumerable);
assertEquals('function', typeof descr.get);
assertEquals(undefined, descr.set);
}
@@ -205,7 +205,7 @@ function assertGetterDescriptor(object, name) {
function assertSetterDescriptor(object, name) {
var descr = Object.getOwnPropertyDescriptor(object, name);
assertTrue(descr.configurable);
- assertTrue(descr.enumerable);
+ assertFalse(descr.enumerable);
assertEquals(undefined, descr.get);
assertEquals('function', typeof descr.set);
}
@@ -214,7 +214,7 @@ function assertSetterDescriptor(object, name) {
function assertAccessorDescriptor(object, name) {
var descr = Object.getOwnPropertyDescriptor(object, name);
assertTrue(descr.configurable);
- assertTrue(descr.enumerable);
+ assertFalse(descr.enumerable);
assertEquals('function', typeof descr.get);
assertEquals('function', typeof descr.set);
}

Powered by Google App Engine
This is Rietveld 408576698