src/x64/full-codegen-x64.cc - Issue 896643003: Class methods should be non enumerable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: formatting Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 3a93117e385542c259016c087242a171bed3c289..33bb32e2861edec0532f3159f1dd37939923ba9f 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -1781,11 +1781,13 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

break;

case ObjectLiteral::Property::GETTER:

- __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3);

+ __ Push(Smi::FromInt(NONE));

+ __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);

break;

case ObjectLiteral::Property::SETTER:

- __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3);

+ __ Push(Smi::FromInt(NONE));

+ __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);

break;

}

@@ -2471,11 +2473,13 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {

break;

case ObjectLiteral::Property::GETTER:

- __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3);

+ __ Push(Smi::FromInt(DONT_ENUM));

+ __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);

break;

case ObjectLiteral::Property::SETTER:

- __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3);

+ __ Push(Smi::FromInt(DONT_ENUM));

+ __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);

break;

default: