src/objects.cc - Issue 896643003: Class methods should be non enumerable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: formatting Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 28c6ebb47ed393300ff5e9a73de2b6b5b06f51d4..39f325781d96f32c062799e106822aae98f134d9 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -12725,9 +12725,11 @@ MaybeHandle<Object> JSReceiver::SetElement(Handle<JSReceiver> object,

MaybeHandle<Object> JSObject::SetOwnElement(Handle<JSObject> object,

uint32_t index,

Handle<Object> value,

+ PropertyAttributes attributes,

StrictMode strict_mode) {

DCHECK(!object->HasExternalArrayElements());

- return JSObject::SetElement(object, index, value, NONE, strict_mode, false);

+ return JSObject::SetElement(object, index, value, attributes, strict_mode,

+ false);

}