Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: formatting Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 87b0b2ddab3337879e2772be12a6605872b76168..131195f98782469be6ecec9e73546f5f628dbe29 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1339,15 +1339,17 @@ void AstGraphBuilder::VisitClassLiteralContents(ClassLiteral* expr) {
break;
}
case ObjectLiteral::Property::GETTER: {
+ Node* attr = jsgraph()->Constant(DONT_ENUM);
const Operator* op = javascript()->CallRuntime(
- Runtime::kDefineGetterPropertyUnchecked, 3);
- NewNode(op, receiver, key, value);
+ Runtime::kDefineGetterPropertyUnchecked, 4);
+ NewNode(op, receiver, key, value, attr);
break;
}
case ObjectLiteral::Property::SETTER: {
+ Node* attr = jsgraph()->Constant(DONT_ENUM);
const Operator* op = javascript()->CallRuntime(
- Runtime::kDefineSetterPropertyUnchecked, 3);
- NewNode(op, receiver, key, value);
+ Runtime::kDefineSetterPropertyUnchecked, 4);
+ NewNode(op, receiver, key, value, attr);
break;
}
}
@@ -1582,16 +1584,18 @@ void AstGraphBuilder::VisitObjectLiteral(ObjectLiteral* expr) {
break;
}
case ObjectLiteral::Property::GETTER: {
+ Node* attr = jsgraph()->Constant(NONE);
const Operator* op = javascript()->CallRuntime(
- Runtime::kDefineGetterPropertyUnchecked, 3);
- Node* call = NewNode(op, receiver, key, value);
+ Runtime::kDefineGetterPropertyUnchecked, 4);
+ Node* call = NewNode(op, receiver, key, value, attr);
PrepareFrameState(call, BailoutId::None());
break;
}
case ObjectLiteral::Property::SETTER: {
+ Node* attr = jsgraph()->Constant(NONE);
const Operator* op = javascript()->CallRuntime(
- Runtime::kDefineSetterPropertyUnchecked, 3);
- Node* call = NewNode(op, receiver, key, value);
+ Runtime::kDefineSetterPropertyUnchecked, 4);
+ Node* call = NewNode(op, receiver, key, value, attr);
PrepareFrameState(call, BailoutId::None());
break;
}

Powered by Google App Engine
This is Rietveld 408576698