Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: formatting Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1729 matching lines...) Expand 10 before | Expand all | Expand 10 after
1740 } else { 1740 } else {
1741 __ Drop(3); 1741 __ Drop(3);
1742 } 1742 }
1743 break; 1743 break;
1744 1744
1745 case ObjectLiteral::Property::PROTOTYPE: 1745 case ObjectLiteral::Property::PROTOTYPE:
1746 UNREACHABLE(); 1746 UNREACHABLE();
1747 break; 1747 break;
1748 1748
1749 case ObjectLiteral::Property::GETTER: 1749 case ObjectLiteral::Property::GETTER:
1750 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 1750 __ push(Immediate(Smi::FromInt(NONE)));
1751 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
1751 break; 1752 break;
1752 1753
1753 case ObjectLiteral::Property::SETTER: 1754 case ObjectLiteral::Property::SETTER:
1754 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 1755 __ push(Immediate(Smi::FromInt(NONE)));
1756 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
1755 break; 1757 break;
1756 } 1758 }
1757 } 1759 }
1758 } 1760 }
1759 1761
1760 if (expr->has_function()) { 1762 if (expr->has_function()) {
1761 DCHECK(result_saved); 1763 DCHECK(result_saved);
1762 __ push(Operand(esp, 0)); 1764 __ push(Operand(esp, 0));
1763 __ CallRuntime(Runtime::kToFastProperties, 1); 1765 __ CallRuntime(Runtime::kToFastProperties, 1);
1764 } 1766 }
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
2465 switch (property->kind()) { 2467 switch (property->kind()) {
2466 case ObjectLiteral::Property::CONSTANT: 2468 case ObjectLiteral::Property::CONSTANT:
2467 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2469 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2468 case ObjectLiteral::Property::PROTOTYPE: 2470 case ObjectLiteral::Property::PROTOTYPE:
2469 UNREACHABLE(); 2471 UNREACHABLE();
2470 case ObjectLiteral::Property::COMPUTED: 2472 case ObjectLiteral::Property::COMPUTED:
2471 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2473 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2472 break; 2474 break;
2473 2475
2474 case ObjectLiteral::Property::GETTER: 2476 case ObjectLiteral::Property::GETTER:
2475 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 2477 __ push(Immediate(Smi::FromInt(DONT_ENUM)));
2478 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
2476 break; 2479 break;
2477 2480
2478 case ObjectLiteral::Property::SETTER: 2481 case ObjectLiteral::Property::SETTER:
2479 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 2482 __ push(Immediate(Smi::FromInt(DONT_ENUM)));
2483 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
2480 break; 2484 break;
2481 } 2485 }
2482 } 2486 }
2483 2487
2484 // prototype 2488 // prototype
2485 __ CallRuntime(Runtime::kToFastProperties, 1); 2489 __ CallRuntime(Runtime::kToFastProperties, 1);
2486 2490
2487 // constructor 2491 // constructor
2488 __ CallRuntime(Runtime::kToFastProperties, 1); 2492 __ CallRuntime(Runtime::kToFastProperties, 1);
2489 } 2493 }
(...skipping 2786 matching lines...) Expand 10 before | Expand all | Expand 10 after
5276 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5280 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5277 Assembler::target_address_at(call_target_address, 5281 Assembler::target_address_at(call_target_address,
5278 unoptimized_code)); 5282 unoptimized_code));
5279 return OSR_AFTER_STACK_CHECK; 5283 return OSR_AFTER_STACK_CHECK;
5280 } 5284 }
5281 5285
5282 5286
5283 } } // namespace v8::internal 5287 } } // namespace v8::internal
5284 5288
5285 #endif // V8_TARGET_ARCH_IA32 5289 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698