Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: formatting Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1789 matching lines...) Expand 10 before | Expand all | Expand 10 after
1800 } else { 1800 } else {
1801 __ Drop(3); 1801 __ Drop(3);
1802 } 1802 }
1803 break; 1803 break;
1804 1804
1805 case ObjectLiteral::Property::PROTOTYPE: 1805 case ObjectLiteral::Property::PROTOTYPE:
1806 UNREACHABLE(); 1806 UNREACHABLE();
1807 break; 1807 break;
1808 1808
1809 case ObjectLiteral::Property::GETTER: 1809 case ObjectLiteral::Property::GETTER:
1810 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 1810 __ Mov(x0, Smi::FromInt(NONE));
1811 __ Push(x0);
1812 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
1811 break; 1813 break;
1812 1814
1813 case ObjectLiteral::Property::SETTER: 1815 case ObjectLiteral::Property::SETTER:
1814 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 1816 __ Mov(x0, Smi::FromInt(NONE));
1817 __ Push(x0);
1818 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
1815 break; 1819 break;
1816 } 1820 }
1817 } 1821 }
1818 } 1822 }
1819 1823
1820 if (expr->has_function()) { 1824 if (expr->has_function()) {
1821 DCHECK(result_saved); 1825 DCHECK(result_saved);
1822 __ Peek(x0, 0); 1826 __ Peek(x0, 0);
1823 __ Push(x0); 1827 __ Push(x0);
1824 __ CallRuntime(Runtime::kToFastProperties, 1); 1828 __ CallRuntime(Runtime::kToFastProperties, 1);
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
2249 switch (property->kind()) { 2253 switch (property->kind()) {
2250 case ObjectLiteral::Property::CONSTANT: 2254 case ObjectLiteral::Property::CONSTANT:
2251 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2255 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2252 case ObjectLiteral::Property::PROTOTYPE: 2256 case ObjectLiteral::Property::PROTOTYPE:
2253 UNREACHABLE(); 2257 UNREACHABLE();
2254 case ObjectLiteral::Property::COMPUTED: 2258 case ObjectLiteral::Property::COMPUTED:
2255 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2259 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2256 break; 2260 break;
2257 2261
2258 case ObjectLiteral::Property::GETTER: 2262 case ObjectLiteral::Property::GETTER:
2259 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 2263 __ Mov(x0, Smi::FromInt(DONT_ENUM));
2264 __ Push(x0);
2265 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
2260 break; 2266 break;
2261 2267
2262 case ObjectLiteral::Property::SETTER: 2268 case ObjectLiteral::Property::SETTER:
2263 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 2269 __ Mov(x0, Smi::FromInt(DONT_ENUM));
2270 __ Push(x0);
2271 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
2264 break; 2272 break;
2265 2273
2266 default: 2274 default:
2267 UNREACHABLE(); 2275 UNREACHABLE();
2268 } 2276 }
2269 } 2277 }
2270 2278
2271 // prototype 2279 // prototype
2272 __ CallRuntime(Runtime::kToFastProperties, 1); 2280 __ CallRuntime(Runtime::kToFastProperties, 1);
2273 2281
(...skipping 3111 matching lines...) Expand 10 before | Expand all | Expand 10 after
5385 return previous_; 5393 return previous_;
5386 } 5394 }
5387 5395
5388 5396
5389 #undef __ 5397 #undef __
5390 5398
5391 5399
5392 } } // namespace v8::internal 5400 } } // namespace v8::internal
5393 5401
5394 #endif // V8_TARGET_ARCH_ARM64 5402 #endif // V8_TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698