Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: formatting Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | src/runtime/runtime-object.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1808 matching lines...) Expand 10 before | Expand all | Expand 10 after
1819 } else { 1819 } else {
1820 __ Drop(3); 1820 __ Drop(3);
1821 } 1821 }
1822 break; 1822 break;
1823 1823
1824 case ObjectLiteral::Property::PROTOTYPE: 1824 case ObjectLiteral::Property::PROTOTYPE:
1825 UNREACHABLE(); 1825 UNREACHABLE();
1826 break; 1826 break;
1827 1827
1828 case ObjectLiteral::Property::GETTER: 1828 case ObjectLiteral::Property::GETTER:
1829 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 1829 __ mov(r0, Operand(Smi::FromInt(NONE)));
1830 __ push(r0);
1831 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
1830 break; 1832 break;
1831 1833
1832 case ObjectLiteral::Property::SETTER: 1834 case ObjectLiteral::Property::SETTER:
1833 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 1835 __ mov(r0, Operand(Smi::FromInt(NONE)));
1836 __ push(r0);
1837 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
1834 break; 1838 break;
1835 } 1839 }
1836 } 1840 }
1837 } 1841 }
1838 1842
1839 if (expr->has_function()) { 1843 if (expr->has_function()) {
1840 DCHECK(result_saved); 1844 DCHECK(result_saved);
1841 __ ldr(r0, MemOperand(sp)); 1845 __ ldr(r0, MemOperand(sp));
1842 __ push(r0); 1846 __ push(r0);
1843 __ CallRuntime(Runtime::kToFastProperties, 1); 1847 __ CallRuntime(Runtime::kToFastProperties, 1);
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
2552 switch (property->kind()) { 2556 switch (property->kind()) {
2553 case ObjectLiteral::Property::CONSTANT: 2557 case ObjectLiteral::Property::CONSTANT:
2554 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2558 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2555 case ObjectLiteral::Property::PROTOTYPE: 2559 case ObjectLiteral::Property::PROTOTYPE:
2556 UNREACHABLE(); 2560 UNREACHABLE();
2557 case ObjectLiteral::Property::COMPUTED: 2561 case ObjectLiteral::Property::COMPUTED:
2558 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2562 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2559 break; 2563 break;
2560 2564
2561 case ObjectLiteral::Property::GETTER: 2565 case ObjectLiteral::Property::GETTER:
2562 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 2566 __ mov(r0, Operand(Smi::FromInt(DONT_ENUM)));
2567 __ push(r0);
2568 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
2563 break; 2569 break;
2564 2570
2565 case ObjectLiteral::Property::SETTER: 2571 case ObjectLiteral::Property::SETTER:
2566 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 2572 __ mov(r0, Operand(Smi::FromInt(DONT_ENUM)));
2573 __ push(r0);
2574 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
2567 break; 2575 break;
2568 2576
2569 default: 2577 default:
2570 UNREACHABLE(); 2578 UNREACHABLE();
2571 } 2579 }
2572 } 2580 }
2573 2581
2574 // prototype 2582 // prototype
2575 __ CallRuntime(Runtime::kToFastProperties, 1); 2583 __ CallRuntime(Runtime::kToFastProperties, 1);
2576 2584
(...skipping 2828 matching lines...) Expand 10 before | Expand all | Expand 10 after
5405 5413
5406 DCHECK(interrupt_address == 5414 DCHECK(interrupt_address ==
5407 isolate->builtins()->OsrAfterStackCheck()->entry()); 5415 isolate->builtins()->OsrAfterStackCheck()->entry());
5408 return OSR_AFTER_STACK_CHECK; 5416 return OSR_AFTER_STACK_CHECK;
5409 } 5417 }
5410 5418
5411 5419
5412 } } // namespace v8::internal 5420 } } // namespace v8::internal
5413 5421
5414 #endif // V8_TARGET_ARCH_ARM 5422 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | src/runtime/runtime-object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698