Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/browser/dom_storage/dom_storage_area_unittest.cc

Issue 896643002: [DOMStorage] Rate limiting writes to disk. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: switched to UMA_HISTOGRAM_LONG_TIMES Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/dom_storage/dom_storage_area_unittest.cc
diff --git a/content/browser/dom_storage/dom_storage_area_unittest.cc b/content/browser/dom_storage/dom_storage_area_unittest.cc
index c074cc0709bc0840638e131181d7cdb5160449d4..1115590996b515bab42baf391acafcefc4c60dea 100644
--- a/content/browser/dom_storage/dom_storage_area_unittest.cc
+++ b/content/browser/dom_storage/dom_storage_area_unittest.cc
@@ -472,4 +472,51 @@ TEST_F(DOMStorageAreaTest, DatabaseFileNames) {
base::FilePath().AppendASCII(".extensiononly")));
}
+TEST_F(DOMStorageAreaTest, RateLimiter) {
+ // Limit to 1000 samples per second
+ DOMStorageArea::RateLimiter rate_limiter(
+ 1000, base::TimeDelta::FromSeconds(1));
+
+ // No samples have been added so no time/delay should be needed.
+ EXPECT_EQ(base::TimeDelta(),
+ rate_limiter.ComputeTimeNeeded());
+ EXPECT_EQ(base::TimeDelta(),
+ rate_limiter.ComputeDelayNeeded(base::TimeDelta()));
+ EXPECT_EQ(base::TimeDelta(),
+ rate_limiter.ComputeDelayNeeded(base::TimeDelta::FromDays(1)));
+
+ // Add a seconds worth of samples.
+ rate_limiter.add_samples(1000);
+ EXPECT_EQ(base::TimeDelta::FromSeconds(1),
+ rate_limiter.ComputeTimeNeeded());
+ EXPECT_EQ(base::TimeDelta::FromSeconds(1),
+ rate_limiter.ComputeDelayNeeded(base::TimeDelta()));
+ EXPECT_EQ(base::TimeDelta(),
+ rate_limiter.ComputeDelayNeeded(base::TimeDelta::FromSeconds(1)));
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(250),
+ rate_limiter.ComputeDelayNeeded(
+ base::TimeDelta::FromMilliseconds(750)));
+ EXPECT_EQ(base::TimeDelta(),
+ rate_limiter.ComputeDelayNeeded(
+ base::TimeDelta::FromDays(1)));
+
+ // And another half seconds worth.
+ rate_limiter.add_samples(500);
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(1500),
+ rate_limiter.ComputeTimeNeeded());
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(1500),
+ rate_limiter.ComputeDelayNeeded(base::TimeDelta()));
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(500),
+ rate_limiter.ComputeDelayNeeded(base::TimeDelta::FromSeconds(1)));
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(750),
+ rate_limiter.ComputeDelayNeeded(
+ base::TimeDelta::FromMilliseconds(750)));
+ EXPECT_EQ(base::TimeDelta(),
+ rate_limiter.ComputeDelayNeeded(
+ base::TimeDelta::FromMilliseconds(1500)));
+ EXPECT_EQ(base::TimeDelta(),
+ rate_limiter.ComputeDelayNeeded(
+ base::TimeDelta::FromDays(1)));
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698