Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Side by Side Diff: ui/app_list/views/app_list_view_unittest.cc

Issue 896633005: Remove separate SearchResultListView from ContentsView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@separate_start_page_tile_container
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/app_list/views/contents_view.h » ('j') | ui/app_list/views/contents_view.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/app_list/views/app_list_view.h" 5 #include "ui/app_list/views/app_list_view.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/run_loop.h" 11 #include "base/run_loop.h"
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "base/strings/utf_string_conversions.h" 13 #include "base/strings/utf_string_conversions.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "ui/app_list/app_list_constants.h" 15 #include "ui/app_list/app_list_constants.h"
16 #include "ui/app_list/app_list_switches.h" 16 #include "ui/app_list/app_list_switches.h"
17 #include "ui/app_list/pagination_model.h" 17 #include "ui/app_list/pagination_model.h"
18 #include "ui/app_list/search_box_model.h" 18 #include "ui/app_list/search_box_model.h"
19 #include "ui/app_list/test/app_list_test_model.h" 19 #include "ui/app_list/test/app_list_test_model.h"
20 #include "ui/app_list/test/app_list_test_view_delegate.h" 20 #include "ui/app_list/test/app_list_test_view_delegate.h"
21 #include "ui/app_list/test/test_search_result.h" 21 #include "ui/app_list/test/test_search_result.h"
22 #include "ui/app_list/views/app_list_folder_view.h" 22 #include "ui/app_list/views/app_list_folder_view.h"
23 #include "ui/app_list/views/app_list_main_view.h" 23 #include "ui/app_list/views/app_list_main_view.h"
24 #include "ui/app_list/views/apps_container_view.h" 24 #include "ui/app_list/views/apps_container_view.h"
25 #include "ui/app_list/views/apps_grid_view.h" 25 #include "ui/app_list/views/apps_grid_view.h"
26 #include "ui/app_list/views/contents_view.h" 26 #include "ui/app_list/views/contents_view.h"
27 #include "ui/app_list/views/search_box_view.h" 27 #include "ui/app_list/views/search_box_view.h"
28 #include "ui/app_list/views/search_result_list_view.h"
29 #include "ui/app_list/views/search_result_page_view.h" 28 #include "ui/app_list/views/search_result_page_view.h"
30 #include "ui/app_list/views/search_result_tile_item_view.h" 29 #include "ui/app_list/views/search_result_tile_item_view.h"
31 #include "ui/app_list/views/start_page_view.h" 30 #include "ui/app_list/views/start_page_view.h"
32 #include "ui/app_list/views/test/apps_grid_view_test_api.h" 31 #include "ui/app_list/views/test/apps_grid_view_test_api.h"
33 #include "ui/app_list/views/tile_item_view.h" 32 #include "ui/app_list/views/tile_item_view.h"
34 #include "ui/views/controls/textfield/textfield.h" 33 #include "ui/views/controls/textfield/textfield.h"
35 #include "ui/views/test/views_test_base.h" 34 #include "ui/views/test/views_test_base.h"
36 #include "ui/views/views_delegate.h" 35 #include "ui/views/views_delegate.h"
37 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h" 36 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
38 37
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
593 592
594 // Show the search results. 593 // Show the search results.
595 contents_view->ShowSearchResults(true); 594 contents_view->ShowSearchResults(true);
596 contents_view->Layout(); 595 contents_view->Layout();
597 EXPECT_TRUE(contents_view->IsStateActive(AppListModel::STATE_SEARCH_RESULTS)); 596 EXPECT_TRUE(contents_view->IsStateActive(AppListModel::STATE_SEARCH_RESULTS));
598 597
599 const gfx::Rect default_contents_bounds = 598 const gfx::Rect default_contents_bounds =
600 contents_view->GetDefaultContentsBounds(); 599 contents_view->GetDefaultContentsBounds();
601 EXPECT_EQ(AppListModel::STATE_SEARCH_RESULTS, 600 EXPECT_EQ(AppListModel::STATE_SEARCH_RESULTS,
602 delegate_->GetTestModel()->state()); 601 delegate_->GetTestModel()->state());
603 if (test_type_ == EXPERIMENTAL) { 602 EXPECT_EQ(default_contents_bounds,
604 EXPECT_EQ(default_contents_bounds, 603 contents_view->search_results_page_view()->bounds());
605 contents_view->search_results_page_view()->bounds());
606 } else {
607 EXPECT_EQ(default_contents_bounds,
608 contents_view->search_results_list_view()->bounds());
609 }
610 604
611 // Hide the search results. 605 // Hide the search results.
612 contents_view->ShowSearchResults(false); 606 contents_view->ShowSearchResults(false);
613 contents_view->Layout(); 607 contents_view->Layout();
614 608
615 // Check that we return to the page that we were on before the search. 609 // Check that we return to the page that we were on before the search.
616 EXPECT_TRUE(contents_view->IsStateActive(AppListModel::STATE_APPS)); 610 EXPECT_TRUE(contents_view->IsStateActive(AppListModel::STATE_APPS));
617 EXPECT_EQ(AppListModel::STATE_APPS, delegate_->GetTestModel()->state()); 611 EXPECT_EQ(AppListModel::STATE_APPS, delegate_->GetTestModel()->state());
618 EXPECT_EQ(default_contents_bounds, 612 EXPECT_EQ(default_contents_bounds,
619 contents_view->apps_container_view()->bounds()); 613 contents_view->apps_container_view()->bounds());
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 AppListViewTestAura, 822 AppListViewTestAura,
829 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END)); 823 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
830 #endif 824 #endif
831 825
832 INSTANTIATE_TEST_CASE_P(AppListViewTestDesktopInstance, 826 INSTANTIATE_TEST_CASE_P(AppListViewTestDesktopInstance,
833 AppListViewTestDesktop, 827 AppListViewTestDesktop,
834 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END)); 828 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
835 829
836 } // namespace test 830 } // namespace test
837 } // namespace app_list 831 } // namespace app_list
OLDNEW
« no previous file with comments | « no previous file | ui/app_list/views/contents_view.h » ('j') | ui/app_list/views/contents_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698