Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 896603002: Oilpan: declare and define various inspector class dtors out-of-line. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: declare and define various inspector class dtors out-of-line. The DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED() macro is intended used for class types deriving from the non-finalizing GarbageCollected base class; a convenience macro when declaring the class using transition types. Using the macro for GarbageCollectedFinalized classes as a way to let the compiler synthesize an inlinable destructor, is not recommended and is preferably avoided. Remove DECLARE_EMPTY_DESTRUCTR_WILL_BE_REMOVED() uses of the latter kind. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M Source/core/inspector/ScriptArguments.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptArguments.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptAsyncCallStack.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/ScriptAsyncCallStack.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptCallStack.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/ScriptCallStack.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-02 21:58:51 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-02 23:39:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896603002/1
5 years, 10 months ago (2015-02-03 06:35:40 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 08:53:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189393

Powered by Google App Engine
This is Rietveld 408576698