Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8841)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 896583003: Add risk data to getrealpan request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes for android Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
index 90d8d84762e330924ec36747c291e11334467480..d399f750561c2734b81ea42f38155137ec5c23bd 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
@@ -82,7 +82,6 @@ using testing::_;
const char kSourceUrl[] = "http://localbike.shop";
const char kFakeEmail[] = "user@chromium.org";
-const char kFakeFingerprintEncoded[] = "CgVaAwiACA==";
const char kEditedBillingAddress[] = "123 edited billing address";
const char* kFieldsFromPage[] =
{ "email",
@@ -132,14 +131,6 @@ scoped_ptr<wallet::WalletItems> CompleteAndValidWalletItems() {
return items.Pass();
}
-scoped_ptr<risk::Fingerprint> GetFakeFingerprint() {
- scoped_ptr<risk::Fingerprint> fingerprint(new risk::Fingerprint());
- // Add some data to the proto, else the encoded content is empty.
- fingerprint->mutable_machine_characteristics()->mutable_screen_size()->
- set_width(1024);
- return fingerprint.Pass();
-}
-
bool HasAnyError(const ValidityMessages& messages, ServerFieldType field) {
return !messages.GetMessageOrDefault(field).text.empty();
}
@@ -568,7 +559,7 @@ class AutofillDialogControllerTest : public ChromeRenderViewHostTestHarness {
void AcceptAndLoadFakeFingerprint() {
controller()->OnAccept();
- controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
+ controller()->OnDidLoadRiskFingerprintData("a");
}
// Returns true if the given |section| contains a field of the given |type|.
@@ -1542,7 +1533,7 @@ TEST_F(AutofillDialogControllerTest, AcceptLegalDocuments) {
controller()->OnAccept();
controller()->OnDidAcceptLegalDocuments();
- controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
+ controller()->OnDidLoadRiskFingerprintData("a");
// Now try it all over again with the location disclosure already accepted.
// Nothing should change.
@@ -2438,8 +2429,8 @@ TEST_F(AutofillDialogControllerTest, RiskLoadsAfterAcceptingLegalDocuments) {
// Simulate a risk load and verify |GetRiskData()| matches the encoded value.
controller()->OnDidAcceptLegalDocuments();
- controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
- EXPECT_EQ(kFakeFingerprintEncoded, controller()->GetRiskData());
+ controller()->OnDidLoadRiskFingerprintData("a");
+ EXPECT_EQ("a", controller()->GetRiskData());
}
TEST_F(AutofillDialogControllerTest, NoManageMenuItemForNewWalletUsers) {

Powered by Google App Engine
This is Rietveld 408576698