win/swarming: Make 64-bit debug component builds work on swarming.

win/swarming: Make 64-bit debug component builds work on swarming.

Fixes a small mistake in https://codereview.chromium.org/888783003/ that isn't
at all embarassing and could've happened to anyone. Since I learned a new tool
while debugging this the time it took me to find this wasn't wasted and way
too long either.

BUG=453657, 452057
R=maruel@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/905ca7579a1cabfa3beaafa2e51257af6aa5038e

[Nico, 2015-02-02 20:53:23]

thakis@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2015-02-02 20:55:53]

Ah, missed it too. lgtm

[M-A Ruel, 2015-02-02 20:55:57]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-02-02 20:57:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896583002/20001

[Nico, 2015-02-02 20:59:08]

On 2015/02/02 20:55:53, M-A Ruel wrote:
> Ah, missed it too. lgtm

When I saw that these tests were still red on the debug bots with the same
error, I was looking at that line for typos like 3 times, and only after I
looked at the generated isolated file and saw that msvcp120d.dll was in fact
missing did I see this when I looked the fourth time :-(

Maybe interesting to you: On
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29%20tes...
, courgette_unittests and base_unittests passed (while content_unittests failed
with the expected error message due to this bug). Maybe some of the swarming
machines do have msvc dlls installed and some don't? (That'd be bad.)

[commit-bot: I haz the power, 2015-02-02 21:46:45]

Patchset 2 (id:??) landed as
https://crrev.com/905ca7579a1cabfa3beaafa2e51257af6aa5038e
Cr-Commit-Position: refs/heads/master@{#314193}

[Nico, 2015-02-02 21:46:51]

Committed patchset #2 (id:20001) manually as
905ca7579a1cabfa3beaafa2e51257af6aa5038e (presubmit successful).

[M-A Ruel, 2015-02-02 21:52:37]

On 2015/02/02 20:59:08, Nico wrote:
> Maybe interesting to you: On
>
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29%20tes...
> , courgette_unittests and base_unittests passed (while content_unittests
failed
> with the expected error message due to this bug). Maybe some of the swarming
> machines do have msvc dlls installed and some don't? (That'd be bad.)

Sadly, it's fairly possible. :/

[Nico, 2015-02-03 00:12:20]

On 2015/02/02 21:52:37, M-A Ruel wrote:
> On 2015/02/02 20:59:08, Nico wrote:
> > Maybe interesting to you: On
> >
>
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29%20tes...
> > , courgette_unittests and base_unittests passed (while content_unittests
> failed
> > with the expected error message due to this bug). Maybe some of the swarming
> > machines do have msvc dlls installed and some don't? (That'd be bad.)
> 
> Sadly, it's fairly possible. :/

That sounds bad. Shouldn't it be possible to make sure that all swarming VMs use
the same image?