Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 896533003: Support creation of StackTrace directly from CONTEXT struct (Closed)

Created:
5 years, 10 months ago by Mike Wittman
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support creation of StackTrace directly from CONTEXT struct BUG= Committed: https://crrev.com/7808da74e1af4cc7b136205f44166dd3e180454f Cr-Commit-Position: refs/heads/master@{#314361}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M base/debug/stack_trace.h View 3 chunks +6 lines, -0 lines 0 comments Download
M base/debug/stack_trace_win.cc View 1 2 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mike Wittman
5 years, 10 months ago (2015-02-03 02:08:32 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-03 02:41:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896533003/20001
5 years, 10 months ago (2015-02-03 02:43:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-02-03 04:45:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896533003/20001
5 years, 10 months ago (2015-02-03 17:46:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 17:47:18 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 17:49:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7808da74e1af4cc7b136205f44166dd3e180454f
Cr-Commit-Position: refs/heads/master@{#314361}

Powered by Google App Engine
This is Rietveld 408576698