Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 896503002: [Android] Add LogcatMonitor. (Closed)

Created:
5 years, 10 months ago by jbudorick
Modified:
5 years, 10 months ago
Reviewers:
klundberg, perezju, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, Benoit L
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add LogcatMonitor. LogcatMonitor provides the same functionality as AndroidCommands.WaitForLogMatch and the associated functions. BUG=267773 Committed: https://crrev.com/7103545f9756c669cf3d29085658f9fb159a0d18 Cr-Commit-Position: refs/heads/master@{#314384}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 12

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -104 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 2 chunks +8 lines, -1 line 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 3 chunks +15 lines, -1 line 0 comments Download
A build/android/pylib/device/logcat_monitor.py View 1 2 1 chunk +143 lines, -0 lines 0 comments Download
A build/android/pylib/device/logcat_monitor_test.py View 1 chunk +164 lines, -0 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M build/android/pylib/linker/test_case.py View 1 2 3 6 chunks +22 lines, -68 lines 0 comments Download
M tools/profile_chrome/chrome_controller.py View 1 2 3 7 chunks +17 lines, -17 lines 0 comments Download
M tools/profile_chrome/chrome_startup_controller.py View 1 2 3 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
jbudorick
https://codereview.chromium.org/896503002/diff/1/tools/profile_chrome/chrome_startup_controller.py File tools/profile_chrome/chrome_startup_controller.py (left): https://codereview.chromium.org/896503002/diff/1/tools/profile_chrome/chrome_startup_controller.py#oldcode33 tools/profile_chrome/chrome_startup_controller.py:33: self._device.old_interface.CloseApplication(self._package_info.package) lizeb: I saw that you added this file ...
5 years, 10 months ago (2015-02-02 18:50:28 UTC) #2
jbudorick
https://codereview.chromium.org/896503002/diff/1/tools/profile_chrome/chrome_startup_controller.py File tools/profile_chrome/chrome_startup_controller.py (left): https://codereview.chromium.org/896503002/diff/1/tools/profile_chrome/chrome_startup_controller.py#oldcode33 tools/profile_chrome/chrome_startup_controller.py:33: self._device.old_interface.CloseApplication(self._package_info.package) On 2015/02/02 18:50:28, jbudorick wrote: > lizeb: I ...
5 years, 10 months ago (2015-02-02 18:53:43 UTC) #3
klundberg
LGTM after offline discussion but please wait for Sami's review. https://codereview.chromium.org/896503002/diff/1/build/android/pylib/device/logcat_monitor.py File build/android/pylib/device/logcat_monitor.py (right): https://codereview.chromium.org/896503002/diff/1/build/android/pylib/device/logcat_monitor.py#newcode38 ...
5 years, 10 months ago (2015-02-02 20:00:40 UTC) #4
jbudorick
https://codereview.chromium.org/896503002/diff/1/build/android/pylib/device/logcat_monitor.py File build/android/pylib/device/logcat_monitor.py (right): https://codereview.chromium.org/896503002/diff/1/build/android/pylib/device/logcat_monitor.py#newcode38 build/android/pylib/device/logcat_monitor.py:38: """Waits for a logcat line matching the provided regular ...
5 years, 10 months ago (2015-02-02 21:47:39 UTC) #5
perezju
lgtm, just a small suggestion https://codereview.chromium.org/896503002/diff/20001/build/android/pylib/device/logcat_monitor.py File build/android/pylib/device/logcat_monitor.py (right): https://codereview.chromium.org/896503002/diff/20001/build/android/pylib/device/logcat_monitor.py#newcode37 build/android/pylib/device/logcat_monitor.py:37: def WaitFor(self, success_regex, failure_regex, ...
5 years, 10 months ago (2015-02-03 09:18:44 UTC) #6
Sami
Overall looks like a great cleanup. Added some nits about documentation. https://codereview.chromium.org/896503002/diff/20001/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): ...
5 years, 10 months ago (2015-02-03 14:24:23 UTC) #7
jbudorick
https://codereview.chromium.org/896503002/diff/20001/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/896503002/diff/20001/build/android/pylib/device/device_utils.py#newcode1294 build/android/pylib/device/device_utils.py:1294: """Returns a new LogcatMonitor associated with this device.""" On ...
5 years, 10 months ago (2015-02-03 15:38:02 UTC) #8
Sami
Thank you, lgtm.
5 years, 10 months ago (2015-02-03 18:31:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896503002/60001
5 years, 10 months ago (2015-02-03 18:33:11 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-03 19:39:09 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:40:00 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/7103545f9756c669cf3d29085658f9fb159a0d18
Cr-Commit-Position: refs/heads/master@{#314384}

Powered by Google App Engine
This is Rietveld 408576698