Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 896463005: Add flag to enable Material Design for the PDF Viewer. (Closed)

Created:
5 years, 10 months ago by Alexandre Carlton
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag to enable Material Design for the PDF Viewer. Committed: https://crrev.com/a3f5c416f5a73d0661147713f2e7642b19ba8cb1 Cr-Commit-Position: refs/heads/master@{#314693}

Patch Set 1 #

Patch Set 2 : Add pdf-material-ui entries in histograms.xml #

Total comments: 2

Patch Set 3 : Remove pdf-material-ui entry #

Patch Set 4 : Rebase before commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
Alexandre Carlton
5 years, 10 months ago (2015-02-03 23:25:42 UTC) #2
raymes
lg but you'll need to update the histograms xml file.
5 years, 10 months ago (2015-02-04 00:33:17 UTC) #3
Alexandre Carlton
On 2015/02/04 00:33:17, raymes wrote: > lg but you'll need to update the histograms xml ...
5 years, 10 months ago (2015-02-04 02:39:22 UTC) #4
raymes
https://codereview.chromium.org/896463005/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/896463005/diff/20001/tools/metrics/histograms/histograms.xml#newcode50962 tools/metrics/histograms/histograms.xml:50962: + <int value="993472930" label="pdf-material-ui"/> I don't think we need ...
5 years, 10 months ago (2015-02-04 02:41:54 UTC) #5
raymes
https://codereview.chromium.org/896463005/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/896463005/diff/20001/tools/metrics/histograms/histograms.xml#newcode50962 tools/metrics/histograms/histograms.xml:50962: + <int value="993472930" label="pdf-material-ui"/> I don't think we need ...
5 years, 10 months ago (2015-02-04 02:41:54 UTC) #6
Alexandre Carlton
isherman@chromium.org: Please review changes in tools/metrics/histograms/histograms.xml Thank you. https://codereview.chromium.org/896463005/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/896463005/diff/20001/tools/metrics/histograms/histograms.xml#newcode50962 tools/metrics/histograms/histograms.xml:50962: + ...
5 years, 10 months ago (2015-02-04 02:48:33 UTC) #8
Sam McNally
lgtm
5 years, 10 months ago (2015-02-04 02:51:18 UTC) #9
raymes
lgtm
5 years, 10 months ago (2015-02-04 02:52:19 UTC) #10
benwells
lgtm
5 years, 10 months ago (2015-02-04 17:57:13 UTC) #11
Ilya Sherman
histograms.xml lgtm
5 years, 10 months ago (2015-02-04 23:20:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896463005/40001
5 years, 10 months ago (2015-02-04 23:21:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/55556) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/7497) ios_rel_device_ninja_ng ...
5 years, 10 months ago (2015-02-04 23:25:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896463005/60001
5 years, 10 months ago (2015-02-04 23:39:53 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-05 00:54:02 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:55:34 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a3f5c416f5a73d0661147713f2e7642b19ba8cb1
Cr-Commit-Position: refs/heads/master@{#314693}

Powered by Google App Engine
This is Rietveld 408576698