Issue 896433005: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 896433005: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (3/3) (Closed)

Created:
5 years, 10 months ago by nhiroki

Modified:
5 years, 10 months ago

Reviewers:

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@unregister-1-3

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (3/3) This series of CLs changes a call sequence of unregister API. (See the 1st CL for more details) This 3rd CL switches unregister process from WebSWProvider to WebSWRegistration. CL dependency: (1) Blink: https://codereview.chromium.org/897573002/ (2) Chromium: https://codereview.chromium.org/896533004/ (3) Blink: THIS PATCH BUG=452910 TEST=run-webkit-tests http/tests/serviceworker/

Patch Set 1 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -13 lines)			Patch
	M	Source/modules/serviceworkers/ServiceWorkerRegistration.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	Source/modules/serviceworkers/ServiceWorkerRegistration.cpp	View		5 chunks	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Patchset #1 (id:1) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages