Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: build/config/BUILD.gn

Issue 896413003: GN: Allow users to enable DCHECK on Release builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index c57ba3f317c5da6d4d83040b4e49b53db97d7417..cdda654fb2de77917d3875f25ae7994c90e644c5 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -19,6 +19,9 @@ declare_args() {
# TODO(sebmarchand): Update this comment once this flag guarantee that
# there's no build metadata in the build artifacts.
dont_embed_build_metadata = false
+
+ # Set to true to enable dcheck in release.
Mostyn Bramley-Moore 2015/02/05 16:54:35 nitpick: "in release builds." would be slightly mo
tfarina 2015/02/05 17:05:18 Done. Also for common.gypi
+ dcheck_always_on = false
}
# TODO(brettw) Most of these should be removed. Instead of global feature
@@ -74,6 +77,9 @@ config("feature_flags") {
if (dont_embed_build_metadata) {
defines += [ "DONT_EMBED_BUILD_METADATA" ]
}
+ if (dcheck_always_on) {
+ defines += [ "DCHECK_ALWAYS_ON=1" ]
+ }
if (use_udev) {
# TODO(brettw) should probably be "=1".
defines += [ "USE_UDEV" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698