Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: build/config/BUILD.gn

Issue 896413003: GN: Allow users to enable DCHECK on Release builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Release builds Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/crypto.gni") 6 import("//build/config/crypto.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//build/module_args/v8.gni") 9 import("//build/module_args/v8.gni")
10 10
11 declare_args() { 11 declare_args() {
12 # When set, turns off the (normally-on) iterator debugging and related stuff 12 # When set, turns off the (normally-on) iterator debugging and related stuff
13 # that is normally turned on for Debug builds. These are generally useful for 13 # that is normally turned on for Debug builds. These are generally useful for
14 # catching bugs but in some cases may cause conflicts or excessive slowness. 14 # catching bugs but in some cases may cause conflicts or excessive slowness.
15 disable_iterator_debugging = false 15 disable_iterator_debugging = false
16 16
17 # Set to true to not store any build metadata (this isn't working yet but 17 # Set to true to not store any build metadata (this isn't working yet but
18 # this flag will help us to get there). See http://crbug.com/314403. 18 # this flag will help us to get there). See http://crbug.com/314403.
19 # TODO(sebmarchand): Update this comment once this flag guarantee that 19 # TODO(sebmarchand): Update this comment once this flag guarantee that
20 # there's no build metadata in the build artifacts. 20 # there's no build metadata in the build artifacts.
21 dont_embed_build_metadata = false 21 dont_embed_build_metadata = false
22
23 # Set to true to enable dcheck in Release builds.
24 dcheck_always_on = false
22 } 25 }
23 26
24 # TODO(brettw) Most of these should be removed. Instead of global feature 27 # TODO(brettw) Most of these should be removed. Instead of global feature
25 # flags, we should have more modular flags that apply only to a target and its 28 # flags, we should have more modular flags that apply only to a target and its
26 # dependents. For example, depending on the "x11" meta-target should define 29 # dependents. For example, depending on the "x11" meta-target should define
27 # USE_X11 for all dependents so that everything that could use X11 gets the 30 # USE_X11 for all dependents so that everything that could use X11 gets the
28 # define, but anything that doesn't depend on X11 doesn't see it. 31 # define, but anything that doesn't depend on X11 doesn't see it.
29 # 32 #
30 # For now we define these globally to match the current GYP build. 33 # For now we define these globally to match the current GYP build.
31 config("feature_flags") { 34 config("feature_flags") {
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 # Can be defined without ENABLE_BASIC_PRINTING. 70 # Can be defined without ENABLE_BASIC_PRINTING.
68 defines += [ "ENABLE_PRINT_PREVIEW=1" ] 71 defines += [ "ENABLE_PRINT_PREVIEW=1" ]
69 } 72 }
70 } 73 }
71 if (enable_spellcheck) { 74 if (enable_spellcheck) {
72 defines += [ "ENABLE_SPELLCHECK=1" ] 75 defines += [ "ENABLE_SPELLCHECK=1" ]
73 } 76 }
74 if (dont_embed_build_metadata) { 77 if (dont_embed_build_metadata) {
75 defines += [ "DONT_EMBED_BUILD_METADATA" ] 78 defines += [ "DONT_EMBED_BUILD_METADATA" ]
76 } 79 }
80 if (dcheck_always_on) {
81 defines += [ "DCHECK_ALWAYS_ON=1" ]
82 }
77 if (use_udev) { 83 if (use_udev) {
78 # TODO(brettw) should probably be "=1". 84 # TODO(brettw) should probably be "=1".
79 defines += [ "USE_UDEV" ] 85 defines += [ "USE_UDEV" ]
80 } 86 }
81 if (toolkit_views) { 87 if (toolkit_views) {
82 defines += [ "TOOLKIT_VIEWS=1" ] 88 defines += [ "TOOLKIT_VIEWS=1" ]
83 } 89 }
84 if (ui_compositor_image_transport) { 90 if (ui_compositor_image_transport) {
85 # TODO(brettw) should probably be "=1". 91 # TODO(brettw) should probably be "=1".
86 defines += [ "UI_COMPOSITOR_IMAGE_TRANSPORT" ] 92 defines += [ "UI_COMPOSITOR_IMAGE_TRANSPORT" ]
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 "CoreFoundation.framework", 310 "CoreFoundation.framework",
305 "CoreGraphics.framework", 311 "CoreGraphics.framework",
306 "CoreText.framework", 312 "CoreText.framework",
307 "Foundation.framework", 313 "Foundation.framework",
308 "UIKit.framework", 314 "UIKit.framework",
309 ] 315 ]
310 } else if (is_linux) { 316 } else if (is_linux) {
311 libs = [ "dl" ] 317 libs = [ "dl" ]
312 } 318 }
313 } 319 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698