Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 896403002: Revert of Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test". (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test". (patchset #1 id:1 of https://codereview.chromium.org/899103002/) Reason for revert: Speculatively reverting to try to fix broken Mac 10.8 retina and Nexus 4 layout tests. Original issue's description: > Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test". > > At this point, "--run-layout-test" is the flag that is actually functional, and using "--dump-render-tree" simply causes the "--run-layout-test" to be appended to the command line. > > A subsequent Blink patch will change the scripts in Blink to use "--run-layout-test" instead of "--dump-render-tree". > > BUG=453252 > > Committed: https://crrev.com/7066b52aa7103b402dea27c64ec17d45c373a838 > Cr-Commit-Position: refs/heads/master@{#314664} TBR=avi@chromium.org,paulmeyer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453252 Committed: https://crrev.com/4d353255acdd6735c78ef15960203553f68ce26b Cr-Commit-Position: refs/heads/master@{#314756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -43 lines) Patch
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/content_browser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 4 chunks +4 lines, -10 lines 0 comments Download
M content/shell/app/shell_main_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/common/shell_content_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/common/shell_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/common/shell_switches.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M content/shell/tools/breakpad_integration_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test".
5 years, 10 months ago (2015-02-05 04:43:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896403002/1
5 years, 10 months ago (2015-02-05 04:43:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 04:44:34 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 04:45:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d353255acdd6735c78ef15960203553f68ce26b
Cr-Commit-Position: refs/heads/master@{#314756}

Powered by Google App Engine
This is Rietveld 408576698