ui/views/controls/button/text_button.cc - Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/text_button.cc

Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: don't need to override IsFocusableInRootView in omnibox_view_views Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/text_button.cc

diff --git a/ui/views/controls/button/text_button.cc b/ui/views/controls/button/text_button.cc

index 46b37b3d31fa300fe709c453a8dbffd66c68f9c6..38a80217d2b19d4735a3311862a4f6ab4d927e49 100644

--- a/ui/views/controls/button/text_button.cc

+++ b/ui/views/controls/button/text_button.cc

@@ -753,7 +753,7 @@ std::string TextButton::GetClassName() const {

}

void TextButton::OnPaintFocusBorder(gfx::Canvas* canvas) {

- if ((IsFocusable() || IsAccessibilityFocusableInRootView()) && HasFocus()) {

+ if ((focusable() || IsAccessibilityFocusableInRootView()) && HasFocus()) {

gfx::Rect rect(GetLocalBounds());

rect.Inset(kFocusRectInset, kFocusRectInset);

canvas->DrawFocusRect(rect);

@@ -841,7 +841,7 @@ std::string NativeTextButton::GetClassName() const {

void NativeTextButton::OnPaintFocusBorder(gfx::Canvas* canvas) {

#if defined(OS_WIN)

- if ((IsFocusable() || IsAccessibilityFocusableInRootView()) && HasFocus()) {

+ if ((focusable() || IsAccessibilityFocusableInRootView()) && HasFocus()) {

gfx::Rect rect(GetLocalBounds());

rect.Inset(kFocusRectInset, kFocusRectInset);

canvas->DrawFocusRect(rect);

« no previous file with comments | « ui/views/controls/button/custom_button.cc ('k') | ui/views/controls/label.cc » ('j') | no next file with comments »