ui/views/controls/button/checkbox.cc - Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/checkbox.cc

Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: don't need to override IsFocusableInRootView in omnibox_view_views Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc ('k') | ui/views/controls/button/custom_button.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/button/checkbox.cc

diff --git a/ui/views/controls/button/checkbox.cc b/ui/views/controls/button/checkbox.cc

index 1221efa8d2d66f82153d11c6bc570fa24ea402e2..ef36dc131506c2010fffa77beef36aa595b96fd8 100644

--- a/ui/views/controls/button/checkbox.cc

+++ b/ui/views/controls/button/checkbox.cc

@@ -61,7 +61,7 @@ void Checkbox::GetAccessibleState(ui::AccessibleViewState* state) {

}

void Checkbox::OnPaintFocusBorder(gfx::Canvas* canvas) {

- if (HasFocus() && (IsFocusable() || IsAccessibilityFocusableInRootView())) {

+ if (HasFocus() && (focusable() || IsAccessibilityFocusableInRootView())) {

gfx::Rect bounds(GetTextBounds());

// Increate the bounding box by one on each side so that that focus border

// does not draw on top of the letters.