chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc - Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc

Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: don't need to override IsFocusableInRootView in omnibox_view_views Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.h ('k') | chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc

diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc

index e6e1dc75f8d3ae72bbaa734d14ea815bd44cd39e..74681c5e0dbccd9a1a221398898ba9e1ce177fb8 100644

--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc

+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc

@@ -97,7 +97,7 @@ views::FocusTraversable* NativeTabContentsContainerGtk::GetFocusTraversable() {

return NULL;

}

-bool NativeTabContentsContainerGtk::IsFocusable() const {

+bool NativeTabContentsContainerGtk::IsFocusableInRootView() const {

// We need to be focusable when our contents is not a view hierarchy, as

// clicking on the contents needs to focus us.

return container_->tab_contents() != NULL;