chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: don't need to override IsFocusableInRootView in omnibox_view_views Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/views/dropdown_button.cc ('k') | chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index 139b5d9abac1dac9e056b0eecdb89153177ccea1..d8000ec8be46cfba04a915e9baebf28f4f192def 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -71,12 +71,6 @@ class AutocompleteTextfield : public views::Textfield {

return omnibox_view_->HandleKeyReleaseEvent(event);

}

- virtual bool IsFocusable() const OVERRIDE {

- // Bypass Textfield::IsFocusable. The omnibox in popup window requires

- // focus in order for text selection to work.

- return views::View::IsFocusable();

- }

virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE {

return omnibox_view_->HandleMousePressEvent(event);

}