Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 896393005: Add new method to get negotiated SSL cipher in jingle glue. (Closed)

Created:
5 years, 10 months ago by fancycode
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new method to get negotiated SSL cipher in jingle glue. This is required to re-land CL 26009004 in webrtc (was reverted due to compiler errors while rolling webrtc into chromium): https://webrtc-codereview.appspot.com/26009004/ BUG=https://code.google.com/p/webrtc/issues/detail?id=3976 Committed: https://crrev.com/bc321c76ace6e1d5a03440e554ccb207159802ec Cr-Commit-Position: refs/heads/master@{#315370}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M jingle/glue/channel_socket_adapter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
fancycode
ptal, I compiled and ran the "jingle_unittests" from a fresh Chromium checkout.
5 years, 10 months ago (2015-02-08 14:31:13 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 10 months ago (2015-02-08 17:23:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896393005/1
5 years, 10 months ago (2015-02-08 17:24:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41270)
5 years, 10 months ago (2015-02-08 17:30:04 UTC) #9
fancycode
On 2015/02/08 17:30:04, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-08 19:53:14 UTC) #11
Sergey Ulanov
lgtm
5 years, 10 months ago (2015-02-09 18:02:07 UTC) #12
tommi (sloooow) - chröme
On 2015/02/08 19:53:14, fancycode wrote: > On 2015/02/08 17:30:04, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-09 19:22:03 UTC) #13
fancycode
On 2015/02/09 19:22:03, tommi wrote: > Can you add yourself to the AUTHORS file please ...
5 years, 10 months ago (2015-02-09 19:30:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896393005/20001
5 years, 10 months ago (2015-02-09 19:35:18 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 20:14:19 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 20:14:55 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc321c76ace6e1d5a03440e554ccb207159802ec
Cr-Commit-Position: refs/heads/master@{#315370}

Powered by Google App Engine
This is Rietveld 408576698