Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 896393003: Create brillo wrapper command. (Closed)

Created:
5 years, 10 months ago by dgarrett
Modified:
5 years, 10 months ago
Reviewers:
bsimonnet, sosa, Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, sosa, agable
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Create brillo wrapper command. Add support for 'brillo' as an entry command distinct from 'cros'. It still does exactly the same thing... for now. BUG=brillo:162 TEST=Ran "brillo help" successfully. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + brillo View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dgarrett
This requires the following CL to work properly: https://chromium-review.googlesource.com/#/c/246563/1
5 years, 10 months ago (2015-02-05 18:59:39 UTC) #2
dgarrett
This trvial CL creates a working placeholder for the brillo commands based on the cros ...
5 years, 10 months ago (2015-02-11 00:52:12 UTC) #4
Dirk Pranke
lgtm lgtm, assuming that will actually create a symlink like cros is.
5 years, 10 months ago (2015-02-11 00:54:34 UTC) #6
bsimonnet
On 2015/02/11 00:54:34, Dirk Pranke wrote: > lgtm > > lgtm, assuming that will actually ...
5 years, 10 months ago (2015-02-11 00:55:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896393003/1
5 years, 10 months ago (2015-02-11 00:56:16 UTC) #9
dgarrett
On 2015/02/11 00:55:08, bsimonnet wrote: > On 2015/02/11 00:54:34, Dirk Pranke wrote: > > lgtm ...
5 years, 10 months ago (2015-02-11 00:56:24 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 00:58:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294021

Powered by Google App Engine
This is Rietveld 408576698