Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 896393002: Revert of Revert of Make Reflector Use Main Thread MessageLoop when in SingleThread (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
danakj, weiliangc
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, enne (OOO), jam, jbauman+watch_chromium.org, kalyank, oshima, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@turnitoff
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Make Reflector Use Main Thread MessageLoop when in SingleThread (patchset #1 id:1 of https://codereview.chromium.org/900133002/) Reason for revert: These aren't the changes you're looking for. Original issue's description: > Revert of Make Reflector Use Main Thread MessageLoop when in SingleThread (patchset #1 id:1 of https://codereview.chromium.org/899073003/) > > Reason for revert: > Reason for revert: > Speculatively reverting to try to fix broken Mac 10.8 retina layout tests in Blink: > compositing/iframes/iframe-composited-scrolling-hide-and-show.html > compositing/iframes/overlapped-iframe-iframe.html > svg/as-border-image/svg-as-border-image-2.html > and more. > > Original issue's description: > > Make Reflector Use Main Thread MessageLoop when in SingleThread > > > > When in using single thread with browser compositor, make reflector use > > main thread MessageLoop instead. > > > > Test with forced SW mirrored display on both Linux-cros build and Pixel. > > BUG=453732 > > > > Committed: https://crrev.com/0b88b2372f1ad82c12656a4b9a17098470e576a1 > > Cr-Commit-Position: refs/heads/master@{#314665} > > TBR=danakj@chromium.org,weiliangc@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=453732 > > Committed: https://crrev.com/6cb534f690545ebda6751d153a6e72f50d4003cc > Cr-Commit-Position: refs/heads/master@{#314732} TBR=danakj@chromium.org,weiliangc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453732 Committed: https://crrev.com/76330a38ff306d6ee24fbfab35d13e7c9ff1d8ea Cr-Commit-Position: refs/heads/master@{#314748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M content/browser/compositor/reflector_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 3 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Revert of Make Reflector Use Main Thread MessageLoop when in SingleThread
5 years, 10 months ago (2015-02-05 04:03:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896393002/1
5 years, 10 months ago (2015-02-05 04:03:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 04:04:44 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 04:06:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76330a38ff306d6ee24fbfab35d13e7c9ff1d8ea
Cr-Commit-Position: refs/heads/master@{#314748}

Powered by Google App Engine
This is Rietveld 408576698