add length parameter to addText, to match attr values

add length parameter to addText, to match attr values

BUG=skia:3392
Committed: https://skia.googlesource.com/skia/+/e73da40c35672f34ad77beee0c9fcd4761fab108

[reed1, 2015-02-05 02:09:37]

reed@google.com changed reviewers:
+ fmalita@google.com, mtklein@google.com

[reed1, 2015-02-05 02:09:38]

ptal

[reed1, 2015-02-05 02:09:42]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-02-05 02:10:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896363002/1

[commit-bot: I haz the power, 2015-02-05 02:10:33]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-05 08:10 UTC

[f(malita), 2015-02-05 02:16:16]

fmalita@chromium.org changed reviewers:
+ fmalita@chromium.org

[f(malita), 2015-02-05 02:16:17]

https://codereview.chromium.org/896363002/diff/1/include/xml/SkXMLWriter.h
File include/xml/SkXMLWriter.h (right):

https://codereview.chromium.org/896363002/diff/1/include/xml/SkXMLWriter.h#ne...
include/xml/SkXMLWriter.h:29: void    addText(const char cstr[]);
Is there any value in keeping this variant around? SkSVGDevice is the only user
atm.

https://codereview.chromium.org/896363002/diff/1/src/xml/SkXMLWriter.cpp
File src/xml/SkXMLWriter.cpp (right):

https://codereview.chromium.org/896363002/diff/1/src/xml/SkXMLWriter.cpp#newc...
src/xml/SkXMLWriter.cpp:242: fStream.writeText(text);
If we're accepting explicit text lengths, we shouldn't ignore them.

[reed1, 2015-02-05 02:17:45]

https://codereview.chromium.org/896363002/diff/1/include/xml/SkXMLWriter.h
File include/xml/SkXMLWriter.h (right):

https://codereview.chromium.org/896363002/diff/1/include/xml/SkXMLWriter.h#ne...
include/xml/SkXMLWriter.h:29: void    addText(const char cstr[]);
On 2015/02/05 02:16:17, f(malita) wrote:
> Is there any value in keeping this variant around? SkSVGDevice is the only
user
> atm.

Good point. Will remove.

https://codereview.chromium.org/896363002/diff/1/src/xml/SkXMLWriter.cpp
File src/xml/SkXMLWriter.cpp (right):

https://codereview.chromium.org/896363002/diff/1/src/xml/SkXMLWriter.cpp#newc...
src/xml/SkXMLWriter.cpp:242: fStream.writeText(text);
On 2015/02/05 02:16:17, f(malita) wrote:
> If we're accepting explicit text lengths, we shouldn't ignore them.

Yikes, good catch. Will fix.

[reed1, 2015-02-05 02:24:10]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-02-05 02:24:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896363002/20001

[commit-bot: I haz the power, 2015-02-05 02:24:12]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-05 08:24 UTC

[reed1, 2015-02-05 02:24:16]

ptal

[f(malita), 2015-02-05 02:27:49]

lgtm

[commit-bot: I haz the power, 2015-02-05 02:29:31]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e73da40c35672f34ad77beee0c9fcd4761fab108