Add one test for Cryptographer::InstallKeys

Add one test for Cryptographer::InstallKeys

Add a test which covers the case of exporting all the keys
and installing them back to fully bootstrap another cryptographer.

Committed: https://crrev.com/a17a62ab89a227166c665a4da0391c02111152ae
Cr-Commit-Position: refs/heads/master@{#317008}

[uzer, 2015-02-04 19:23:46]

malets@yandex-team.ru changed reviewers:
+ nick@semenkovich.com

[uzer, 2015-02-04 19:24:15]

Please take a look.

[nick, 2015-02-04 20:27:56]

On 2015/02/04 19:24:15, uzer wrote:
> Please take a look.

Wrong nick.

[uzer, 2015-02-04 20:32:48]

malets@yandex-team.ru changed reviewers:
+ zea@google.com
- nick@semenkovich.com

[uzer, 2015-02-04 20:33:23]

On 2015/02/04 20:27:56, nick wrote:
> On 2015/02/04 19:24:15, uzer wrote:
> > Please take a look.
> 
> Wrong nick.

Oops, sorry.

[uzer, 2015-02-18 20:13:08]

malets@yandex-team.ru changed reviewers:
+ rlarocque@chromium.org

[uzer, 2015-02-18 20:14:08]

2 weeks passed, adding one more reviewer.

[rlarocque, 2015-02-18 21:46:39]

rlarocque@chromium.org changed reviewers:
+ pavely@chromium.org, stanisc@chromium.org

[rlarocque, 2015-02-18 21:46:40]

I'm sorry this has taken so long, and sorry that it's going to take a little bit
longer.  I'm no longer working on Chromium, so I'd prefer to delegate the review
to someone more involved in that code base.

Maybe +pavely or +stanisc could help you.  They've been CC'ed on this e-mail.

[pavely, 2015-02-18 22:31:46]

lgtm with small comment.

https://codereview.chromium.org/896313002/diff/1/sync/util/cryptographer_unit...
File sync/util/cryptographer_unittest.cc (right):

https://codereview.chromium.org/896313002/diff/1/sync/util/cryptographer_unit...
sync/util/cryptographer_unittest.cc:267: TEST_F(CryptographerTest,
GetKeysThenInstall) {
Could you add comment describing test?

Test verifies that GetBootstrapToken/Bootstrap only transfers default key.
Additional call to GetKeys/InstallKeys is needed to transfer keybag to decrypt
messages encrypted with old keys.

[uzer, 2015-02-19 07:39:35]

New patchsets have been uploaded after l-g-t-m from pavely@chromium.org

[uzer, 2015-02-19 07:42:35]

The CQ bit was checked by malets@yandex-team.ru

[commit-bot: I haz the power, 2015-02-19 07:42:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896313002/20001

[commit-bot: I haz the power, 2015-02-19 08:23:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 08:24:22]

Patchset 2 (id:??) landed as
https://crrev.com/a17a62ab89a227166c665a4da0391c02111152ae
Cr-Commit-Position: refs/heads/master@{#317008}