Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

Issue 896303003: Revert of Temporarily upload minidump to private cloud storage on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py
index 4982261b16f051bc8a6e316f59e982df56fbaa06..ede5078188dff54a8cbf9a6831401862669514a9 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import datetime
import glob
import heapq
import logging
@@ -18,7 +17,6 @@
from telemetry.core import util
from telemetry.core.backends import browser_backend
from telemetry.core.backends.chrome import chrome_browser_backend
-from telemetry.util import cloud_storage
from telemetry.util import path
from telemetry.util import support_binaries
@@ -328,19 +326,6 @@
return subprocess.check_output([stackwalk, minidump, symbols_path],
stderr=open(os.devnull, 'w'))
- def _UploadMinidumpToCloudStorage(self, minidump_path):
- os_name = self.browser.platform.GetOSName()
- if os_name == 'win':
- try:
- remote_path = ('minidump-%s.dmp' % (
- datetime.datetime.now().strftime('%Y-%m-%d_%H-%M-%S')))
- cloud_url = cloud_storage.Insert(
- cloud_storage.INTERNAL_BUCKET, remote_path, minidump_path)
- print 'View minidump online at %s\n' % cloud_url
- except cloud_storage.PermissionError as e:
- logging.error('Cannot upload minidump to cloud storage due to'
- ' permission error: %s' % e.message)
-
def GetStackTrace(self):
most_recent_dump = self._GetMostRecentMinidump()
if not most_recent_dump:
@@ -348,9 +333,6 @@
self.GetStandardOutput())
logging.info('minidump found: %s' % most_recent_dump)
-
- self._UploadMinidumpToCloudStorage(most_recent_dump)
-
stack = self._GetStackFromMinidump(most_recent_dump)
if not stack:
return 'Failed to symbolize minidump. Returning browser stdout:\n' + (
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698