extensions: don't animate options dialog when loading.

chrome/browser/resources/extensions/extension_options_overlay.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('extensions', function() {
   'use strict';
 
   /**
    * The ExtensionOptionsOverlay will show an extension's options page using
    * an <extensionoptions> element.
@@ skipping 103 matching lines @@
       extensionoptions.onpreferredsizechanged = function(evt) {
         var oldWidth = parseInt(overlayStyle.width, 10);
         var oldHeight = parseInt(overlayStyle.height, 10);
         var newWidth = Math.max(evt.width, minWidth);
         var newHeight = Math.min(evt.height, maxHeight);
 
         // animationTime is the amount of time in ms that will be used to resize
         // the overlay. It is calculated by multiplying the pythagorean distance
         // between old and the new size (in px) with a constant speed of
         // 0.25 ms/px.
-        var animationTime = 0.25 * Math.sqrt(
-            Math.pow(newWidth - oldWidth, 2) +
-            Math.pow(newHeight - oldHeight, 2));
+        var loading = document.documentElement.classlist.contains('loading');

[Dan Beam, 2015/02/04 19:09:30]

note: this doesn't work all that well but will when hcarmona@ or I fix the
constant rebuild issues

+        var animationTime = loading ? 0 :
+            0.25 * Math.sqrt(Math.pow(newWidth - oldWidth, 2) +
+                             Math.pow(newHeight - oldHeight, 2));
 
         if (animation) {
           animation.cancel();
         }
         animation = overlay.animate([
           {width: oldWidth + 'px', height: oldHeight + 'px'},
           {width: newWidth + 'px', height: newHeight + 'px'}
         ], {
           duration: animationTime,
           delay: 0
@@ skipping 36 matching lines @@
           /** @type {HTMLDivElement} */($('extension-options-overlay')) :
           null);
     }
   };
 
   // Export
   return {
     ExtensionOptionsOverlay: ExtensionOptionsOverlay
   };
 });