Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 896283003: extensions: don't animate options dialog when loading. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, hcarmona
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

extensions: don't animate options dialog when loading. Transitions are disabled while loading, so animations should be as well. This happens when chrome://extensions/?options=<id> is navigated to, which shows the dialog immediately. R=kalman@chromium.org BUG=none TEST=load chrome://extensions/?options=<extension_id> and look for needless animation Committed: https://crrev.com/49c190353a2c6c95178e70b517770fd837109251 Cr-Commit-Position: refs/heads/master@{#314649}

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/extensions/extension_options_overlay.js View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Beam
https://codereview.chromium.org/896283003/diff/1/chrome/browser/resources/extensions/extension_options_overlay.js File chrome/browser/resources/extensions/extension_options_overlay.js (right): https://codereview.chromium.org/896283003/diff/1/chrome/browser/resources/extensions/extension_options_overlay.js#newcode124 chrome/browser/resources/extensions/extension_options_overlay.js:124: var loading = document.documentElement.classlist.contains('loading'); note: this doesn't work all ...
5 years, 10 months ago (2015-02-04 19:09:30 UTC) #1
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-04 20:38:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896283003/20001
5 years, 10 months ago (2015-02-04 21:08:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 21:56:20 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:57:32 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49c190353a2c6c95178e70b517770fd837109251
Cr-Commit-Position: refs/heads/master@{#314649}

Powered by Google App Engine
This is Rietveld 408576698