Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
896253003:
Add test specs for TSan bots on the MFYI bots (Closed)
|
Created:
5 years, 10 months ago by Alexander Potapenko Modified:
5 years, 10 months ago Reviewers:
jam CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd test specs for TSan bots on the MFYI bots
BUG=368525, 455243, 455633, 437454, 455679, 454828
R=jam@chromium.org
Committed: https://crrev.com/eca1283a654d6955d002efa3b1816f62430a8cc3
Cr-Commit-Position: refs/heads/master@{#316457}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Remove mojo tests, add browser_tests (swarming enabled, 10 shards #Patch Set 3 : Swap browser_tests and content_browsertests #
Total comments: 2
Patch Set 4 : Added more swarming #Patch Set 5 : rebase #Patch Set 6 : Remove MSan Browser tests #Messages
Total messages: 17 (4 generated)
John, can you please take a look?
https://codereview.chromium.org/896253003/diff/1/testing/buildbot/chromium.me... File testing/buildbot/chromium.memory.fyi.json (right): https://codereview.chromium.org/896253003/diff/1/testing/buildbot/chromium.me... testing/buildbot/chromium.memory.fyi.json:165: "mojo_system_unittests", take out the mojo tests (other than mojo_common_unittests which is testing code in chromium). If we want these tests to be run under tsan, we should add a builder on that waterfall. https://codereview.chromium.org/896253003/diff/1/testing/buildbot/chromium.me... testing/buildbot/chromium.memory.fyi.json:189: "Linux TSan Browser": { The model now is to have one bot which runs the tests and which uses swarming. less column on the waterfall is better :) any reason why these aren't using swarming?
https://codereview.chromium.org/896253003/diff/1/testing/buildbot/chromium.me... File testing/buildbot/chromium.memory.fyi.json (right): https://codereview.chromium.org/896253003/diff/1/testing/buildbot/chromium.me... testing/buildbot/chromium.memory.fyi.json:165: "mojo_system_unittests", On 2015/02/05 21:12:06, jam wrote: > take out the mojo tests (other than mojo_common_unittests which is testing code > in chromium). If we want these tests to be run under tsan, we should add a > builder on that waterfall. I've copied these from "Linux MSan Tests" above. Will remove them for now. https://codereview.chromium.org/896253003/diff/1/testing/buildbot/chromium.me... testing/buildbot/chromium.memory.fyi.json:189: "Linux TSan Browser": { On 2015/02/05 21:12:06, jam wrote: > The model now is to have one bot which runs the tests and which uses swarming. > less column on the waterfall is better :) > > any reason why these aren't using swarming? I was going to first mimic the current non-recipes configuration and then improve it gradually. But you're right, let's just throw in some swarming.
Anything else?
sorry just saw the update. https://codereview.chromium.org/896253003/diff/40001/testing/buildbot/chromiu... File testing/buildbot/chromium.memory.fyi.json (right): https://codereview.chromium.org/896253003/diff/40001/testing/buildbot/chromiu... testing/buildbot/chromium.memory.fyi.json:145: "shards": 10 nit: do you really want 10 shards for content_browsertests? have you timed how long it takes, and how long you want the bot to cycle? also why are you only swarming this one target instead of most?
https://codereview.chromium.org/896253003/diff/40001/testing/buildbot/chromiu... File testing/buildbot/chromium.memory.fyi.json (right): https://codereview.chromium.org/896253003/diff/40001/testing/buildbot/chromiu... testing/buildbot/chromium.memory.fyi.json:145: "shards": 10 On 2015/02/10 20:34:47, jam wrote: > nit: do you really want 10 shards for content_browsertests? have you timed how > long it takes, and how long you want the bot to cycle? Nope. I think I just picked the number used by some other bot or trybot. Perhaps I need to use the same number of shards as ASan and MSan. > > also why are you only swarming this one target instead of most? Ok, will do.
On 2015/02/10 22:28:54, Alexander Potapenko wrote: > https://codereview.chromium.org/896253003/diff/40001/testing/buildbot/chromiu... > File testing/buildbot/chromium.memory.fyi.json (right): > > https://codereview.chromium.org/896253003/diff/40001/testing/buildbot/chromiu... > testing/buildbot/chromium.memory.fyi.json:145: "shards": 10 > On 2015/02/10 20:34:47, jam wrote: > > nit: do you really want 10 shards for content_browsertests? have you timed how > > long it takes, and how long you want the bot to cycle? > Nope. I think I just picked the number used by some other bot or trybot. Perhaps > I need to use the same number of shards as ASan and MSan. > > > > also why are you only swarming this one target instead of most? > Ok, will do. Sorry for the delay. I've added swarming to the tests that are currently swarmed by the Linux ASan bot. We can add more targets and employ sharding if we find this configuration too slow. Can you please take another look?
lgtm
The CQ bit was checked by glider@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896253003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
New patchsets have been uploaded after l-g-t-m from jam@chromium.org
The CQ bit was checked by glider@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896253003/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/eca1283a654d6955d002efa3b1816f62430a8cc3 Cr-Commit-Position: refs/heads/master@{#316457} |
