Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 896243003: Mojo+NaCl: Move generated code to mojo/nacl. (Closed)

Created:
5 years, 10 months ago by teravest
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo+NaCl: Move generated code to mojo/nacl. This change moves generated code for Mojo support in NaCl from mojo/monacl to mojo/nacl. This makes the target directory more consistent across GYP and GN builds. An upcoming change for IRT support will generate a header, which will need a consistent path (relative to include_dirs) across build systems. BUG=454466 Committed: https://crrev.com/99cdffdb116cf608630600bbbf66a37fcf16695e Cr-Commit-Position: refs/heads/master@{#314591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/mojo_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
teravest
5 years, 10 months ago (2015-02-04 17:31:36 UTC) #2
Nick Bray (chromium)
LGTM
5 years, 10 months ago (2015-02-04 18:09:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896243003/1
5 years, 10 months ago (2015-02-04 18:11:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40416)
5 years, 10 months ago (2015-02-04 18:18:11 UTC) #7
teravest
+jamesr for mojo/ OWNERS in Chromium.
5 years, 10 months ago (2015-02-04 18:19:16 UTC) #9
jamesr
I don't know what inverse_depth is but as long as this won't collide with anything ...
5 years, 10 months ago (2015-02-04 18:36:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896243003/1
5 years, 10 months ago (2015-02-04 18:37:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 18:41:18 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99cdffdb116cf608630600bbbf66a37fcf16695e Cr-Commit-Position: refs/heads/master@{#314591}
5 years, 10 months ago (2015-02-04 18:42:23 UTC) #14
teravest
5 years, 10 months ago (2015-02-04 18:53:12 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/900983002/ by teravest@chromium.org.

The reason for reverting is: Caused build failures on mac bots. Not sure why it
failed there but not on the CQ..

Powered by Google App Engine
This is Rietveld 408576698