Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 896223002: MIPS: Retry "Use a WeakCell in the CallIC type vector." (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Retry "Use a WeakCell in the CallIC type vector." Port 6fc97a19653e03a891d3cd397069d5a10b9ab325 Original commit message: The first try failed because I needed to make a better distinction between clearing ICs according to policy at GC time or unconditional clearing (say, via %ClearFunctionTypeFeedback). It was also blocked by an issue in super constructor calls. This fix (https://codereview.chromium.org/892113002/) needs to land before checking in this CL. BUG= Committed: https://crrev.com/3b400fcb9b234cd9a3e6e90a2b3e3f94ec3ebbd9 Cr-Commit-Position: refs/heads/master@{#26432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -22 lines) Patch
M src/mips/code-stubs-mips.cc View 3 chunks +33 lines, -10 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +13 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +33 lines, -10 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-04 15:38:38 UTC) #2
dusmil.imgtec
LGTM.
5 years, 10 months ago (2015-02-04 15:42:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896223002/1
5 years, 10 months ago (2015-02-04 15:43:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 16:05:18 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 16:05:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b400fcb9b234cd9a3e6e90a2b3e3f94ec3ebbd9
Cr-Commit-Position: refs/heads/master@{#26432}

Powered by Google App Engine
This is Rietveld 408576698