Clean-up refactoring of chrome_content_browser_client to use GetPermissionContext consistently.

chrome/browser/services/gcm/push_messaging_permission_context.cc

Index: chrome/browser/services/gcm/push_messaging_permission_context.cc
diff --git a/chrome/browser/services/gcm/push_messaging_permission_context.cc b/chrome/browser/services/gcm/push_messaging_permission_context.cc
index 0cb23dab9da186fe350965b97e6194d4a79fab53..07a9a414ed5c7e26b3c177721c1d44af67fce549 100644
--- a/chrome/browser/services/gcm/push_messaging_permission_context.cc
+++ b/chrome/browser/services/gcm/push_messaging_permission_context.cc
@@ -63,6 +63,11 @@ ContentSetting PushMessagingPermissionContext::GetPermissionStatus(
 #endif
 }
 
+void PushMessagingPermissionContext::CancelPermissionRequest(
+    content::WebContents* web_contents, const PermissionRequestID& id) {
+  NOTIMPLEMENTED() << "CancelPermission not implemented for push messaging";

[Peter Beverloo, 2015/02/04 14:56:53]

Does Push need to implement CancelPermissionRequest manually because it defers
to notifications? If so, please add a TODO in my name to fix this.

Otherwise, would you mind clarifying? I notice that other overrides of
CancelPermissionRequest add custom logic prior to falling back to
PermissionContextBase::CancelPermissionRequest, which can cancel the permission
bubble or infobar based on |id|, which we also feed to the Notification request
permission system. Shouldn't it just work?

[timvolodine, 2015/02/04 16:15:37]

This was actually meant as a refactoring, and I added this NOTIMPLEMENTED
because it was in the original switch statement in
chrome_content_browser_client.

I think currently only geolocation overrides CancelPermissionRequest. Not sure
why push currently has no support for cancel. Maybe this is related to
crbug.com/453788, where as I understand it there is no infobar to cancel in case
of push permissions..

Anyways I think the fix for this should be in a separate patch. Added a TODO in
your name as you suggested. Do we need a crbug for this?

+}
+
 // Unlike other permissions, push is decided by the following algorithm
 //  - You need to request it from a top level domain
 //  - You need to have notification permission granted.